[Bf-blender-cvs] [33f51ab] master: Better fix for T37545.

[Antony Riakiotakis]

Link is eaten by git but can be found here
http://blenderartists.org/forum/showthread.php?330188-Color-Picker-Square-%28SV-H%29-Inaccurate



On 14 March 2014 01:42, Antony Riakiotakis <noreply at git.blender.org> wrote:

> Commit: 33f51abe4ef82cd8d38fae7408eb6e50d77e4fbc
> Author: Antony Riakiotakis
> Date:   Fri Mar 14 01:37:32 2014 +0200
> https://developer.blender.org/rB33f51abe4ef82cd8d38fae7408eb6e50d77e4fbc
>
> Better fix for T37545.
>
> This was supposed to fix inaccuracies between S-H wheel but it makes the
> colors selected through the SV-H color cube wrong (see http://
> %28SV-H%29-Inaccurate). Instead of deactivating color management for SV
> and H widgets just reenable correction for the Hue wheel. This is wrong
> because HSV always refers to display space and we -have- to account for
> that when using linear color RNA properties.
>
> ===================================================================
>
> M       source/blender/editors/interface/interface_widgets.c
>
> ===================================================================
>
> diff --git a/source/blender/editors/interface/interface_widgets.c
> b/source/blender/editors/interface/interface_widgets.c
> index d390137..e2f3aac 100644
> --- a/source/blender/editors/interface/interface_widgets.c
> +++ b/source/blender/editors/interface/interface_widgets.c
> @@ -2270,8 +2270,7 @@ bool ui_hsvcube_use_display_colorspace(uiBut *but)
>                         color_profile = false;
>         }
>
> -       /* SV+H gradient does not use display colorspace */
> -       return color_profile && !ELEM((int)but->a1, UI_GRAD_SV, UI_GRAD_H);
> +       return color_profile;
>  }
>
>  void ui_hsvcube_pos_from_vals(uiBut *but, const rcti *rect, float *hsv,
> float *xp, float *yp)
>
> _______________________________________________
> Bf-blender-cvs mailing list
> Bf-blender-cvs at blender.org
> http://lists.blender.org/mailman/listinfo/bf-blender-cvs
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.blender.org/pipermail/bf-blender-cvs/attachments/20140314/d69ac159/attachment.html>