[Bf-blender-cvs] [2f03ccc] master: No preemptive removal of muted and reroute nodes from compositor node trees for localization (previews and viewer evaluation).

Lukas Tönne noreply at git.blender.org
Tue Jul 15 11:04:48 CEST 2014


Commit: 2f03cccecd1eaa5c95daa7a75b3d0c57e7d0e038
Author: Lukas Tönne
Date:   Tue Jul 15 11:00:59 2014 +0200
https://developer.blender.org/rB2f03cccecd1eaa5c95daa7a75b3d0c57e7d0e038

No preemptive removal of muted and reroute nodes from compositor node
trees for localization (previews and viewer evaluation).

This is handled entirely by the compositor already. Doing this during
localization is redundant and risks divergent behavior.

===================================================================

M	source/blender/nodes/composite/node_composite_tree.c

===================================================================

diff --git a/source/blender/nodes/composite/node_composite_tree.c b/source/blender/nodes/composite/node_composite_tree.c
index cd69cf4..6d5b85d 100644
--- a/source/blender/nodes/composite/node_composite_tree.c
+++ b/source/blender/nodes/composite/node_composite_tree.c
@@ -104,9 +104,9 @@ static void free_cache(bNodeTree *ntree)
 }
 
 /* local tree then owns all compbufs */
-static void localize(bNodeTree *localtree, bNodeTree *ntree)
+static void localize(bNodeTree *UNUSED(localtree), bNodeTree *ntree)
 {
-	bNode *node, *node_next;
+	bNode *node;
 	bNodeSocket *sock;
 	
 	for (node = ntree->nodes.first; node; node = node->next) {
@@ -132,26 +132,6 @@ static void localize(bNodeTree *localtree, bNodeTree *ntree)
 			sock->new_sock->new_sock = sock;
 		}
 	}
-	
-	/* replace muted nodes and reroute nodes by internal links */
-	for (node = localtree->nodes.first; node; node = node_next) {
-		node_next = node->next;
-		
-		if (node->flag & NODE_MUTED || node->type == NODE_REROUTE) {
-			/* make sure the update tag isn't lost when removing the muted node.
-			 * propagate this to all downstream nodes.
-			 */
-			if (node->need_exec) {
-				bNodeLink *link;
-				for (link = localtree->links.first; link; link = link->next)
-					if (link->fromnode == node && link->tonode)
-						link->tonode->need_exec = 1;
-			}
-			
-			nodeInternalRelink(localtree, node);
-			nodeFreeNode(localtree, node);
-		}
-	}
 }
 
 static void local_sync(bNodeTree *localtree, bNodeTree *ntree)




More information about the Bf-blender-cvs mailing list