[Bf-blender-cvs] [b722054] master: Make memory checker happy about FileGlobal

Sergey Sharybin noreply at git.blender.org
Wed Jan 22 11:33:05 CET 2014


Commit: b722054db3f7d78646bd17b59ff05a9a501303c8
Author: Sergey Sharybin
Date:   Wed Jan 22 16:23:55 2014 +0600
https://developer.blender.org/rBb722054db3f7d78646bd17b59ff05a9a501303c8

Make memory checker happy about FileGlobal

FileGlobal structure in write_global() didn't initialize
the while build_hash property and only placed there null
terminated meaningful content, leaving trailing uninitialized.

This made valgrind complain about using uninitialized memory
later in undo stack.

===================================================================

M	source/blender/blenloader/intern/writefile.c

===================================================================

diff --git a/source/blender/blenloader/intern/writefile.c b/source/blender/blenloader/intern/writefile.c
index b60459e..238ba0c 100644
--- a/source/blender/blenloader/intern/writefile.c
+++ b/source/blender/blenloader/intern/writefile.c
@@ -3274,6 +3274,7 @@ static void write_global(WriteData *wd, int fileflags, Main *mainvar)
 	/* prevent mem checkers from complaining */
 	fg.pads= 0;
 	memset(fg.filename, 0, sizeof(fg.filename));
+	memset(fg.build_hash, 0, sizeof(fg.build_hash));
 
 	current_screen_compat(mainvar, &screen);




More information about the Bf-blender-cvs mailing list