[Bf-blender-cvs] [a0f25f2] master: Fix own mistake with zealous check for face splitting

Campbell Barton noreply at git.blender.org
Tue Jan 21 02:30:48 CET 2014


Commit: a0f25f23010207725afaa92f6b744eaa529484c1
Author: Campbell Barton
Date:   Tue Jan 21 12:27:38 2014 +1100
https://developer.blender.org/rBa0f25f23010207725afaa92f6b744eaa529484c1

Fix own mistake with zealous check for face splitting

Was disallowing adjacent loops to be split which is correct for a single
split across a face, but not fore BM_face_split_n

===================================================================

M	source/blender/bmesh/intern/bmesh_mods.c
M	source/blender/editors/space_node/drawnode.c

===================================================================

diff --git a/source/blender/bmesh/intern/bmesh_mods.c b/source/blender/bmesh/intern/bmesh_mods.c
index 6d8dc53..a7e3c12 100644
--- a/source/blender/bmesh/intern/bmesh_mods.c
+++ b/source/blender/bmesh/intern/bmesh_mods.c
@@ -365,10 +365,10 @@ BMFace *BM_face_split_n(BMesh *bm, BMFace *f,
 
 	BLI_assert(l_a != l_b);
 	BLI_assert(f == l_a->f && f == l_b->f);
-	BLI_assert(!BM_loop_is_adjacent(l_a, l_b));
+	BLI_assert(!((n == 0) && BM_loop_is_adjacent(l_a, l_b)));
 
 	/* could be an assert */
-	if (UNLIKELY(BM_loop_is_adjacent(l_a, l_b))) {
+	if (UNLIKELY((n == 0) && BM_loop_is_adjacent(l_a, l_b))) {
 		return NULL;
 	}
 
diff --git a/source/blender/editors/space_node/drawnode.c b/source/blender/editors/space_node/drawnode.c
index e8547b7..5f133ae 100644
--- a/source/blender/editors/space_node/drawnode.c
+++ b/source/blender/editors/space_node/drawnode.c
@@ -659,7 +659,7 @@ static void node_buts_image_user(uiLayout *layout, bContext *C, PointerRNA *ptr,
 		/* don't use iuser->framenr directly because it may not be updated if auto-refresh is off */
 		Scene *scene = CTX_data_scene(C);
 		ImageUser *iuser = iuserptr->data;
-		Image *ima = imaptr->data;
+		/* Image *ima = imaptr->data; */  /* UNUSED */
 
 		char numstr[32];
 		const int framenr = BKE_image_user_frame_get(iuser, CFRA, 0, NULL);




More information about the Bf-blender-cvs mailing list