[Bf-blender-cvs] [cc35ad2] master: Fix for random crash in localized node group freeing while tweaking group default values.

Lukas Tönne noreply at git.blender.org
Fri Jan 10 09:42:21 CET 2014


Commit: cc35ad2b3d1b9f48f517fd2ed053076251de7bf1
Author: Lukas Tönne
Date:   Fri Jan 10 09:34:10 2014 +0100
https://developer.blender.org/rBcc35ad2b3d1b9f48f517fd2ed053076251de7bf1

Fix for random crash in localized node group freeing while tweaking
group default values.

This can happen when using value sliders for node group input values.
The localized copies were setting the "interface_type" runtime pointer
of the original tree to NULL instead of the new tree (which is created
on-the-fly in general). This type is used in RNA update functions
however, the original tree DNA should not be modified there.

===================================================================

M	source/blender/blenkernel/intern/node.c

===================================================================

diff --git a/source/blender/blenkernel/intern/node.c b/source/blender/blenkernel/intern/node.c
index 6e04f7e..72544cb 100644
--- a/source/blender/blenkernel/intern/node.c
+++ b/source/blender/blenkernel/intern/node.c
@@ -1204,7 +1204,7 @@ static bNodeTree *ntreeCopyTree_internal(bNodeTree *ntree, Main *bmain, bool do_
 	}
 	
 	/* node tree will generate its own interface type */
-	ntree->interface_type = NULL;
+	newtree->interface_type = NULL;
 	
 	return newtree;
 }




More information about the Bf-blender-cvs mailing list