[Bf-blender-cvs] [fa88c7f] master: Fix T38105: Action Editor refresh is missing when a keyframe is inserted in 3D view

Thomas Beck noreply at git.blender.org
Wed Jan 8 17:57:52 CET 2014


Commit: fa88c7ffae0cfca83b8ec3daaba6c3cc39f9ae34
Author: Thomas Beck
Date:   Wed Jan 8 17:50:25 2014 +0100
https://developer.blender.org/rBfa88c7ffae0cfca83b8ec3daaba6c3cc39f9ae34

Fix T38105: Action Editor refresh is missing when a keyframe is inserted in 3D view

 When yiz insert a keyframe (on a location keying set f.e.) in the 3D-view and you got an action editor open then the action datablock is  not changed (displaying only the button "new") until you hover the action editor with the mouse.

 Added a handler in the action_header_area_listener to handle this case

If non-obvious, some technical note about what the cause of the bug was and
how it was solved.

===================================================================

M	source/blender/editors/space_action/space_action.c

===================================================================

diff --git a/source/blender/editors/space_action/space_action.c b/source/blender/editors/space_action/space_action.c
index fdccedd..990af78 100644
--- a/source/blender/editors/space_action/space_action.c
+++ b/source/blender/editors/space_action/space_action.c
@@ -450,8 +450,11 @@ static void action_listener(bScreen *UNUSED(sc), ScrArea *sa, wmNotifier *wmn)
 	}
 }
 
-static void action_header_area_listener(bScreen *UNUSED(sc), ScrArea *UNUSED(sa), ARegion *ar, wmNotifier *wmn)
+static void action_header_area_listener(bScreen *UNUSED(sc), ScrArea *sa, ARegion *ar, wmNotifier *wmn)
 {
+
+	SpaceAction *saction = (SpaceAction *)sa->spacedata.first;
+
 	/* context changes */
 	switch (wmn->category) {
 		case NC_SCENE:
@@ -465,7 +468,16 @@ static void action_header_area_listener(bScreen *UNUSED(sc), ScrArea *UNUSED(sa)
 			if (wmn->action == NA_RENAME)
 				ED_region_tag_redraw(ar);
 			break;
+		case NC_ANIMATION:
+			switch (wmn->data) {
+				case ND_KEYFRAME:
+					saction->flag |= SACTION_TEMP_NEEDCHANSYNC;
+					ED_region_tag_redraw(ar);
+					break;
+			}
+			break;
 	}
+
 }
 
 static void action_refresh(const bContext *C, ScrArea *sa)




More information about the Bf-blender-cvs mailing list