[Bf-blender-cvs] [dcd2a8f] master: Fix stupid typo that broke split normal shading in edit mode, when there was some deform modifiers.
Bastien Montagne
noreply at git.blender.org
Sun Apr 20 23:16:53 CEST 2014
Commit: dcd2a8fcc4e9b1edfcde4df05e9c9e6192d2ac87
Author: Bastien Montagne
Date: Sun Apr 20 23:12:18 2014 +0200
https://developer.blender.org/rBdcd2a8fcc4e9b1edfcde4df05e9c9e6192d2ac87
Fix stupid typo that broke split normal shading in edit mode, when there was some deform modifiers.
===================================================================
M source/blender/blenkernel/intern/editderivedmesh.c
M source/blender/bmesh/intern/bmesh_mesh.c
===================================================================
diff --git a/source/blender/blenkernel/intern/editderivedmesh.c b/source/blender/blenkernel/intern/editderivedmesh.c
index d4af176..f172455 100644
--- a/source/blender/blenkernel/intern/editderivedmesh.c
+++ b/source/blender/blenkernel/intern/editderivedmesh.c
@@ -180,6 +180,7 @@ static void emDM_calcLoopNormals(DerivedMesh *dm, const float split_angle)
/* calculate loop normals from poly and vertex normals */
emDM_ensureVertNormals(bmdm);
+ emDM_ensurePolyNormals(bmdm);
dm->dirty &= ~DM_DIRTY_NORMALS;
vertexCos = bmdm->vertexCos;
diff --git a/source/blender/bmesh/intern/bmesh_mesh.c b/source/blender/bmesh/intern/bmesh_mesh.c
index e723353..70660bb 100644
--- a/source/blender/bmesh/intern/bmesh_mesh.c
+++ b/source/blender/bmesh/intern/bmesh_mesh.c
@@ -473,7 +473,7 @@ static void bm_mesh_edges_sharp_tag(BMesh *bm, const float (*vnos)[3], const flo
if (BM_edge_loop_pair(e, &l_a, &l_b)) {
bool is_angle_smooth = true;
if (check_angle) {
- const float *no_a = fnos ? fnos[BM_elem_index_get(l_b->f)] : l_a->f->no;
+ const float *no_a = fnos ? fnos[BM_elem_index_get(l_a->f)] : l_a->f->no;
const float *no_b = fnos ? fnos[BM_elem_index_get(l_b->f)] : l_b->f->no;
is_angle_smooth = (dot_v3v3(no_a, no_b) >= split_angle);
}
More information about the Bf-blender-cvs
mailing list