[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [59831] branches/soc-2013-depsgraph_mt/ source/blender: Mark some TODOs as solved.

Sergey Sharybin sergey.vfx at gmail.com
Thu Sep 5 14:23:17 CEST 2013


Revision: 59831
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=59831
Author:   nazgul
Date:     2013-09-05 12:23:17 +0000 (Thu, 05 Sep 2013)
Log Message:
-----------
Mark some TODOs as solved.

Some of them were actually out-of-date, some other didn't
need any code changes (code was good after double-check).

Modified Paths:
--------------
    branches/soc-2013-depsgraph_mt/source/blender/blenkernel/intern/anim.c
    branches/soc-2013-depsgraph_mt/source/blender/blenkernel/intern/pointcache.c
    branches/soc-2013-depsgraph_mt/source/blender/modifiers/intern/MOD_array.c

Modified: branches/soc-2013-depsgraph_mt/source/blender/blenkernel/intern/anim.c
===================================================================
--- branches/soc-2013-depsgraph_mt/source/blender/blenkernel/intern/anim.c	2013-09-05 12:23:12 UTC (rev 59830)
+++ branches/soc-2013-depsgraph_mt/source/blender/blenkernel/intern/anim.c	2013-09-05 12:23:17 UTC (rev 59831)
@@ -368,7 +368,6 @@
 	   *    that doesn't force complete update, but for now, this is the
 	   *    most accurate way!
 	   */
-	/* TODO(sergey): Is it actctually always viewport or not? */
 	BKE_scene_update_for_newframe_viewport(G.main, scene, scene->lay); /* XXX this is the best way we can get anything moving */
 #endif
 }

Modified: branches/soc-2013-depsgraph_mt/source/blender/blenkernel/intern/pointcache.c
===================================================================
--- branches/soc-2013-depsgraph_mt/source/blender/blenkernel/intern/pointcache.c	2013-09-05 12:23:12 UTC (rev 59830)
+++ branches/soc-2013-depsgraph_mt/source/blender/blenkernel/intern/pointcache.c	2013-09-05 12:23:17 UTC (rev 59831)
@@ -3161,7 +3161,6 @@
 	efra = data->endframe;
 
 	for (; (*data->cfra_ptr <= data->endframe) && !data->break_operation; *data->cfra_ptr+=data->step) {
-		/* TODO(sergey): Is it actctually always viewport or not? */
 		BKE_scene_update_for_newframe_viewport(data->main, data->scene, data->scene->lay);
 		if (G.background) {
 			printf("bake: frame %d :: %d\n", (int)*data->cfra_ptr, data->endframe);

Modified: branches/soc-2013-depsgraph_mt/source/blender/modifiers/intern/MOD_array.c
===================================================================
--- branches/soc-2013-depsgraph_mt/source/blender/modifiers/intern/MOD_array.c	2013-09-05 12:23:12 UTC (rev 59830)
+++ branches/soc-2013-depsgraph_mt/source/blender/modifiers/intern/MOD_array.c	2013-09-05 12:23:17 UTC (rev 59831)
@@ -351,7 +351,6 @@
 	BMOpSlot *slot_targetmap = NULL;  /* for weld_op */
 
 	/* need to avoid infinite recursion here */
-	/* TODO(sergey): We shouldn't build other object's DM from modifier stack! */
 	if (amd->start_cap && amd->start_cap != ob && amd->start_cap->type == OB_MESH)
 		start_cap = get_operand_dm(amd->start_cap, flag);
 	if (amd->end_cap && amd->end_cap != ob && amd->end_cap->type == OB_MESH)




More information about the Bf-blender-cvs mailing list