[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [59767] trunk/blender/source/blender/ editors/mesh/editmesh_knife.c: Fix a possible bug in knife detected by coverity.

Howard Trickey howard.trickey at gmail.com
Tue Sep 3 13:37:48 CEST 2013


Revision: 59767
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=59767
Author:   howardt
Date:     2013-09-03 11:37:47 +0000 (Tue, 03 Sep 2013)
Log Message:
-----------
Fix a possible bug in knife detected by coverity.

A selection copy may have been passed a null pointer.
Also quieted a couple other complaints by coverity.

Modified Paths:
--------------
    trunk/blender/source/blender/editors/mesh/editmesh_knife.c

Modified: trunk/blender/source/blender/editors/mesh/editmesh_knife.c
===================================================================
--- trunk/blender/source/blender/editors/mesh/editmesh_knife.c	2013-09-03 10:43:27 UTC (rev 59766)
+++ trunk/blender/source/blender/editors/mesh/editmesh_knife.c	2013-09-03 11:37:47 UTC (rev 59767)
@@ -1320,6 +1320,7 @@
 
 					hit.kfe = kfe;
 					hit.v = NULL;
+					hit.l = 0.0f;
 
 					knife_find_basef(kfe);
 					hit.f = kfe->basef;
@@ -1694,7 +1695,7 @@
 		if (fptr)
 			*fptr = f;
 
-		if (cure && p) {
+		if (cure) {
 			if (!kcd->ignore_edge_snapping || !(cure->e)) {
 				KnifeVert *edgesnap = NULL;
 
@@ -1787,7 +1788,7 @@
 			if (fptr)
 				*fptr = f;
 
-			if (curv && p) {
+			if (curv) {
 				copy_v3_v3(p, curv->co);
 				copy_v3_v3(cagep, curv->cageco);
 
@@ -2725,7 +2726,7 @@
 			BM_edge_select_set(bm, l_new->e, true);
 		}
 	}
-	else {
+	else if (f_new) {
 		BM_elem_select_copy(bm, bm, f_new, f);
 	}
 




More information about the Bf-blender-cvs mailing list