[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [55441] trunk/blender: add back -Wredundant-decls, just not for older gcc's

Campbell Barton ideasman42 at gmail.com
Wed Mar 20 14:30:21 CET 2013


Revision: 55441
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=55441
Author:   campbellbarton
Date:     2013-03-20 13:30:20 +0000 (Wed, 20 Mar 2013)
Log Message:
-----------
add back -Wredundant-decls, just not for older gcc's

Modified Paths:
--------------
    trunk/blender/CMakeLists.txt
    trunk/blender/source/blender/editors/space_view3d/view3d_edit.c

Modified: trunk/blender/CMakeLists.txt
===================================================================
--- trunk/blender/CMakeLists.txt	2013-03-20 13:17:35 UTC (rev 55440)
+++ trunk/blender/CMakeLists.txt	2013-03-20 13:30:20 UTC (rev 55441)
@@ -1936,7 +1936,8 @@
 
 	# versions before gcc4.6 give many BLI_math warnings
 	if (NOT "${CMAKE_C_COMPILER_VERSION}" VERSION_LESS "4.6")
-		ADD_CHECK_C_COMPILER_FLAG(C_WARNINGS C_WARN_REDUNDANT_DECLS -Wredundant-decls)
+		ADD_CHECK_C_COMPILER_FLAG(C_WARNINGS C_WARN_REDUNDANT_DECLS       -Wredundant-decls)
+		ADD_CHECK_CXX_COMPILER_FLAG(CXX_WARNINGS CXX_WARN_REDUNDANT_DECLS -Wredundant-decls)
 	endif()
 
 	# disable because it gives warnings for printf() & friends.
@@ -1953,7 +1954,6 @@
 	ADD_CHECK_CXX_COMPILER_FLAG(CXX_WARNINGS CXX_WARN_INIT_SELF -Winit-self)  # needs -Wuninitialized
 	ADD_CHECK_CXX_COMPILER_FLAG(CXX_WARNINGS CXX_WARN_MISSING_INCLUDE_DIRS -Wmissing-include-dirs)
 	ADD_CHECK_CXX_COMPILER_FLAG(CXX_WARNINGS CXX_WARN_NO_DIV_BY_ZERO -Wno-div-by-zero)
-	# ADD_CHECK_CXX_COMPILER_FLAG(CXX_WARNINGS CXX_WARN_REDUNDANT_DECLS -Wredundant-decls)
 
 	# gcc 4.2 gives annoying warnings on every file with this
 	if (NOT "${CMAKE_C_COMPILER_VERSION}" VERSION_LESS "4.3")

Modified: trunk/blender/source/blender/editors/space_view3d/view3d_edit.c
===================================================================
--- trunk/blender/source/blender/editors/space_view3d/view3d_edit.c	2013-03-20 13:17:35 UTC (rev 55440)
+++ trunk/blender/source/blender/editors/space_view3d/view3d_edit.c	2013-03-20 13:30:20 UTC (rev 55441)
@@ -3962,7 +3962,7 @@
 	return 1;
 }
 
-/* no 4x4 sampling, run view_autodist_init first */
+/* no 4x4 sampling, run #ED_view3d_autodist_init first */
 int ED_view3d_autodist_simple(ARegion *ar, const int mval[2], float mouse_worldloc[3],
                               int margin, float *force_depth)
 {




More information about the Bf-blender-cvs mailing list