[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [54975] branches/soc-2008-mxcurioni/source /blender/freestyle/intern/blender_interface/BlenderStrokeRenderer.cpp: Fix for a buffer overflow, by simply removing the unnecessary string copy.
Tamito Kajiyama
rd6t-kjym at asahi-net.or.jp
Sat Mar 2 19:43:06 CET 2013
Revision: 54975
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=54975
Author: kjym3
Date: 2013-03-02 18:43:06 +0000 (Sat, 02 Mar 2013)
Log Message:
-----------
Fix for a buffer overflow, by simply removing the unnecessary string copy.
Review comment from Campbell.
Modified Paths:
--------------
branches/soc-2008-mxcurioni/source/blender/freestyle/intern/blender_interface/BlenderStrokeRenderer.cpp
Modified: branches/soc-2008-mxcurioni/source/blender/freestyle/intern/blender_interface/BlenderStrokeRenderer.cpp
===================================================================
--- branches/soc-2008-mxcurioni/source/blender/freestyle/intern/blender_interface/BlenderStrokeRenderer.cpp 2013-03-02 18:31:32 UTC (rev 54974)
+++ branches/soc-2008-mxcurioni/source/blender/freestyle/intern/blender_interface/BlenderStrokeRenderer.cpp 2013-03-02 18:43:06 UTC (rev 54975)
@@ -175,8 +175,7 @@
for (Base *b = (Base*)freestyle_scene->base.first; b; b = b->next) {
Object *ob = b->object;
void *data = ob->data;
- char name[24];
- strcpy(name, ob->id.name);
+ char *name = ob->id.name;
#if 0
if (G.debug & G_DEBUG_FREESTYLE) {
cout << "removing " << name[0] << name[1] << ":" << (name+2) << endl;
More information about the Bf-blender-cvs
mailing list