[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [57411] trunk/blender/source/blender: Bugfix [#35668] Tooltip for Euler Discontinuity Filter was misleading

[Joshua Leung]

Revision: 57411
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=57411
Author:   aligorith
Date:     2013-06-12 12:32:07 +0000 (Wed, 12 Jun 2013)
Log Message:
-----------
Bugfix [#35668] Tooltip for Euler Discontinuity Filter was misleading

The tooltip seemed to hint that this tool is able to resolve all manner of
gimble-lock situations by untangling the curves (i.e. performing some kind of
equivalent-angles resolution, keeping in mind the nearest situations nearby).
However, this tool currently only performs corrections for the most basic case
when large jump+flip discontinuity artifacts appear in euler rotation curves as
a result of rotation values getting clipped to +/- 180 degrees, which arises
when these rotation curves are the result of baking some physics sim or so.

(Also, fixed an unrelated "replace-all" typo in a comment)

Modified Paths:
--------------
    trunk/blender/source/blender/blenkernel/intern/nla.c
    trunk/blender/source/blender/editors/space_graph/graph_edit.c

Modified: trunk/blender/source/blender/blenkernel/intern/nla.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/nla.c	2013-06-12 11:26:44 UTC (rev 57410)
+++ trunk/blender/source/blender/blenkernel/intern/nla.c	2013-06-12 12:32:07 UTC (rev 57411)
@@ -503,7 +503,7 @@
 
 
 /* Non clipped mapping for strip-time <-> global time
- *	mode = eNlaTime_ConvertModesp[] -> NLATIME_CONVERT_*
+ *	mode = eNlaTime_ConvertModes -> NLATIME_CONVERT_*
  *
  * Public API method - perform this mapping using the given AnimData block
  * and perform any necessary sanity checks on the value

Modified: trunk/blender/source/blender/editors/space_graph/graph_edit.c
===================================================================
--- trunk/blender/source/blender/editors/space_graph/graph_edit.c	2013-06-12 11:26:44 UTC (rev 57410)
+++ trunk/blender/source/blender/editors/space_graph/graph_edit.c	2013-06-12 12:32:07 UTC (rev 57411)
@@ -1745,7 +1745,9 @@
 	/* identifiers */
 	ot->name = "Euler Discontinuity Filter";
 	ot->idname = "GRAPH_OT_euler_filter";
-	ot->description = "Fixes the most common causes of gimbal lock in the selected Euler Rotation F-Curves";
+	ot->description = "Fix large jumps and flips in the selected "
+	                  "Euler Rotation F-Curves arising from rotation "
+	                  "values being clipped when baking physics";
 	
 	/* api callbacks */
 	ot->exec = graphkeys_euler_filter_exec;