[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [58672] trunk/blender/source/blender/ blenkernel/intern/deform.c: fix for BKE_deform_split_suffix()

Campbell Barton ideasman42 at gmail.com
Sat Jul 27 20:16:22 CEST 2013


Revision: 58672
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=58672
Author:   campbellbarton
Date:     2013-07-27 18:16:22 +0000 (Sat, 27 Jul 2013)
Log Message:
-----------
fix for BKE_deform_split_suffix()
- out of bounds read when passing in empty string.
- single character prefix didnt work.
- with no suffix, the string body was truncated.

Modified Paths:
--------------
    trunk/blender/source/blender/blenkernel/intern/deform.c

Modified: trunk/blender/source/blender/blenkernel/intern/deform.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/deform.c	2013-07-27 18:09:49 UTC (rev 58671)
+++ trunk/blender/source/blender/blenkernel/intern/deform.c	2013-07-27 18:16:22 UTC (rev 58672)
@@ -537,7 +537,7 @@
 
 	body[0] = suf[0] = '\0';
 
-	for (i = len - 1; i > 1; i--) {
+	for (i = len; i > 0; i--) {
 		if (is_char_sep(string[i])) {
 			BLI_strncpy(body, string, i + 1);
 			BLI_strncpy(suf, string + i,  (len + 1) - i);
@@ -545,7 +545,7 @@
 		}
 	}
 
-	BLI_strncpy(body, string, len);
+	memcpy(body, string, len + 1);
 }
 
 /* "a.b.c" -> ("a.", "b.c") */




More information about the Bf-blender-cvs mailing list