[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [58124] trunk/blender/source/blender: Partial revert of rev58110

Sergey Sharybin sergey.vfx at gmail.com
Tue Jul 9 20:38:33 CEST 2013


Revision: 58124
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=58124
Author:   nazgul
Date:     2013-07-09 18:38:33 +0000 (Tue, 09 Jul 2013)
Log Message:
-----------
Partial revert of rev58110

There's one thing we didn't foresee from the beginning,
which is apparently TLS is only available in OSX starting
from version 10.7, and we still do support of 10.6.

After recent Brecht's changes about locked viewport
while initializing BI render this TLS is not needed
in trunk anymore. So reverting this chunk of base
iteration to use static variable. But leaving all the
other static variables warped into context still, it
should help a bit in the future refactor.

Real fix would be to have some kind of graph context
evaluation structure which would be passing to update
routines (which will solve threaded mballs update) and
making depsgraph responsible for getting a motherball.
But this is all for GSoC project.

Revision Links:
--------------
    http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=58110

Modified Paths:
--------------
    trunk/blender/source/blender/blenkernel/intern/scene.c
    trunk/blender/source/blender/blenlib/BLI_threads.h

Modified: trunk/blender/source/blender/blenkernel/intern/scene.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/scene.c	2013-07-09 13:50:22 UTC (rev 58123)
+++ trunk/blender/source/blender/blenkernel/intern/scene.c	2013-07-09 18:38:33 UTC (rev 58124)
@@ -748,7 +748,7 @@
  */
 int BKE_scene_base_iter_next(SceneBaseIter *iter, Scene **scene, int val, Base **base, Object **ob)
 {
-	static ThreadVariable int in_next_object = 0;
+	static int in_next_object = 0;
 	int run_again = 1;
 	
 	/* init */

Modified: trunk/blender/source/blender/blenlib/BLI_threads.h
===================================================================
--- trunk/blender/source/blender/blenlib/BLI_threads.h	2013-07-09 13:50:22 UTC (rev 58123)
+++ trunk/blender/source/blender/blenlib/BLI_threads.h	2013-07-09 18:38:33 UTC (rev 58124)
@@ -182,13 +182,6 @@
 void BLI_thread_queue_wait_finish(ThreadQueue *queue);
 void BLI_thread_queue_nowait(ThreadQueue *queue);
 
-/* Thread Local Storage */
-#ifdef _MSC_VER
-#  define ThreadVariable  __declspec(thread)
-#else
-#  define ThreadVariable  __thread
-#endif
-
 #ifdef __cplusplus
 }
 #endif




More information about the Bf-blender-cvs mailing list