[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [58099] trunk/blender/source/blender/bmesh /operators/bmo_normals.c: fix for own error in normal-recalc r58077, initial face flipping wasn't checking against face-island center.

Campbell Barton ideasman42 at gmail.com
Tue Jul 9 03:18:17 CEST 2013


Revision: 58099
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=58099
Author:   campbellbarton
Date:     2013-07-09 01:18:15 +0000 (Tue, 09 Jul 2013)
Log Message:
-----------
fix for own error in normal-recalc r58077, initial face flipping wasn't checking against face-island center.

Revision Links:
--------------
    http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=58077

Modified Paths:
--------------
    trunk/blender/source/blender/bmesh/operators/bmo_normals.c

Modified: trunk/blender/source/blender/bmesh/operators/bmo_normals.c
===================================================================
--- trunk/blender/source/blender/bmesh/operators/bmo_normals.c	2013-07-09 01:14:52 UTC (rev 58098)
+++ trunk/blender/source/blender/bmesh/operators/bmo_normals.c	2013-07-09 01:18:15 UTC (rev 58099)
@@ -56,7 +56,7 @@
  */
 static void bmo_recalc_face_normals_array(BMesh *bm, BMFace **faces, const int faces_len, const short oflag)
 {
-	float cent[3];
+	float cent[3], tvec[3];
 	float (*faces_center)[3] = MEM_mallocN(sizeof(*faces_center) * faces_len, __func__);
 	const float cent_fac = 1.0f / (float)faces_len;
 	int i, f_start_index;
@@ -91,7 +91,8 @@
 	}
 
 	/* make sure the starting face has the correct winding */
-	if (dot_v3v3(faces_center[f_start_index], faces[f_start_index]->no) < 0.0f) {
+	sub_v3_v3v3(tvec, faces_center[f_start_index], cent);
+	if (dot_v3v3(tvec, faces[f_start_index]->no) < 0.0f) {
 		BMO_elem_flag_enable(bm, faces[f_start_index], FACE_FLIP);
 	}
 




More information about the Bf-blender-cvs mailing list