[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [58088] trunk/blender/source/blender: minor improvements

[Campbell Barton]

Revision: 58088
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=58088
Author:   campbellbarton
Date:     2013-07-09 00:13:17 +0000 (Tue, 09 Jul 2013)
Log Message:
-----------
minor improvements
- calc normals only check flag when needed.
- keymap, dont get name unless its needed.
- keymap, avoid property lookup.
- idprop debug print, include pointer, helpful for troubleshooting.

Modified Paths:
--------------
    trunk/blender/source/blender/bmesh/intern/bmesh_queries.c
    trunk/blender/source/blender/bmesh/operators/bmo_normals.c
    trunk/blender/source/blender/editors/interface/interface_templates.c
    trunk/blender/source/blender/python/generic/idprop_py_api.c

Modified: trunk/blender/source/blender/bmesh/intern/bmesh_queries.c
===================================================================
--- trunk/blender/source/blender/bmesh/intern/bmesh_queries.c	2013-07-09 00:08:18 UTC (rev 58087)
+++ trunk/blender/source/blender/bmesh/intern/bmesh_queries.c	2013-07-09 00:13:17 UTC (rev 58088)
@@ -1761,7 +1761,7 @@
 
 /**
  * TODO (as we need)
- * - option to walk over edges.
+ * - option to walk over faces by verts.
  * - option to walk over non manifold edges.
  *
  * \param bm  the BMesh.

Modified: trunk/blender/source/blender/bmesh/operators/bmo_normals.c
===================================================================
--- trunk/blender/source/blender/bmesh/operators/bmo_normals.c	2013-07-09 00:08:18 UTC (rev 58087)
+++ trunk/blender/source/blender/bmesh/operators/bmo_normals.c	2013-07-09 00:13:17 UTC (rev 58088)
@@ -166,7 +166,10 @@
 
 		for (j = 0; j < fg_len; j++) {
 			faces_grp[j] = faces_arr[groups_array[fg_sta + j]];
-			is_calc |= BMO_elem_flag_test_bool(bm, faces_grp[j], FACE_FLAG);
+
+			if (is_calc == false) {
+				is_calc = BMO_elem_flag_test_bool(bm, faces_grp[j], FACE_FLAG);
+			}
 		}
 
 		if (is_calc) {

Modified: trunk/blender/source/blender/editors/interface/interface_templates.c
===================================================================
--- trunk/blender/source/blender/editors/interface/interface_templates.c	2013-07-09 00:08:18 UTC (rev 58087)
+++ trunk/blender/source/blender/editors/interface/interface_templates.c	2013-07-09 00:13:17 UTC (rev 58088)
@@ -3018,16 +3018,16 @@
 		/* recurse for nested properties */
 		if (RNA_property_type(prop) == PROP_POINTER) {
 			PointerRNA propptr = RNA_property_pointer_get(ptr, prop);
-			const char *name = RNA_property_ui_name(prop);
 
 			if (propptr.data && RNA_struct_is_a(propptr.type, &RNA_OperatorProperties)) {
+				const char *name = RNA_property_ui_name(prop);
 				template_keymap_item_properties(layout, name, &propptr);
 				continue;
 			}
 		}
 
 		/* add property */
-		uiItemR(flow, ptr, RNA_property_identifier(prop), 0, NULL, ICON_NONE);
+		uiItemFullR(flow, ptr, prop, -1, 0, 0, NULL, ICON_NONE);
 	}
 	RNA_STRUCT_END;
 }

Modified: trunk/blender/source/blender/python/generic/idprop_py_api.c
===================================================================
--- trunk/blender/source/blender/python/generic/idprop_py_api.c	2013-07-09 00:08:18 UTC (rev 58087)
+++ trunk/blender/source/blender/python/generic/idprop_py_api.c	2013-07-09 00:13:17 UTC (rev 58088)
@@ -1531,7 +1531,7 @@
 		ret_str = PyObject_Repr(ret_dict);
 		Py_DECREF(ret_dict);
 
-		printf("IDProperty: %s\n", _PyUnicode_AsString(ret_str));
+		printf("IDProperty(%p): %s\n", prop, _PyUnicode_AsString(ret_str));
 
 		Py_DECREF(ret_str);