[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [57905] trunk/blender/source/blender/ editors/space_graph/space_graph.c: Bugfix [#35744] FCurve select changes on Graph Editor Resize

[Joshua Leung]

Revision: 57905
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=57905
Author:   aligorith
Date:     2013-07-01 14:14:21 +0000 (Mon, 01 Jul 2013)
Log Message:
-----------
Bugfix [#35744] FCurve select changes on Graph Editor Resize

Selection state of F-Curves is lost when resizing the Graph Editor.

The problem was that SIPO_TEMP_NEEDCHANSYNC was getting set in the graph_init()
callback, which gets called everytime the view resizes, and not just the very
first time this happens. However, setting this flag forces the selection state
to the updated/pulled from the scene data.

In the past, it was necessary to set this flag so that we could force F-Curve
colors to get initialised correctly. However, things probably changed at some
point, so this behaviour is no longer needed. At worst now, opening a new graph
editor may not show F-Curve selection correctly synced with the viewport, though
that's easily worked around by reselecting whatever it is in the 3d view.

Modified Paths:
--------------
    trunk/blender/source/blender/editors/space_graph/space_graph.c

Modified: trunk/blender/source/blender/editors/space_graph/space_graph.c
===================================================================
--- trunk/blender/source/blender/editors/space_graph/space_graph.c	2013-07-01 13:57:00 UTC (rev 57904)
+++ trunk/blender/source/blender/editors/space_graph/space_graph.c	2013-07-01 14:14:21 UTC (rev 57905)
@@ -189,7 +189,10 @@
 	}
 	
 	/* force immediate init of any invalid F-Curve colors */
-	sipo->flag |= SIPO_TEMP_NEEDCHANSYNC;
+	/* XXX: but, don't do SIPO_TEMP_NEEDCHANSYNC (i.e. channel select state sync)
+	 * as this is run on each region resize; setting this here will cause selection
+	 * state to be lost on area/region resizing. [#35744]
+	 */
 	ED_area_tag_refresh(sa);
 }