[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [54929] trunk/blender/source/blender/ editors/interface/interface_handlers.c: fix [#33466] alt + mouse wheel
Campbell Barton
ideasman42 at gmail.com
Thu Feb 28 12:39:13 CET 2013
Revision: 54929
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=54929
Author: campbellbarton
Date: 2013-02-28 11:39:13 +0000 (Thu, 28 Feb 2013)
Log Message:
-----------
fix [#33466] alt + mouse wheel
Alt+Mouse Wheel events depended on the button under the mouse being active, else it would change the current frame.
Button re-activation wasn't 100% reliable since it depends on fake mousemove events.
Now keep button active when its executed if the mouse stays over it.
Modified Paths:
--------------
trunk/blender/source/blender/editors/interface/interface_handlers.c
Modified: trunk/blender/source/blender/editors/interface/interface_handlers.c
===================================================================
--- trunk/blender/source/blender/editors/interface/interface_handlers.c 2013-02-28 11:29:27 UTC (rev 54928)
+++ trunk/blender/source/blender/editors/interface/interface_handlers.c 2013-02-28 11:39:13 UTC (rev 54929)
@@ -6145,14 +6145,12 @@
static int ui_handle_button_event(bContext *C, const wmEvent *event, uiBut *but)
{
- uiHandleButtonData *data;
+ uiHandleButtonData *data = but->active;
+ const uiButtonActivateType state_orig = data->state;
uiBlock *block;
ARegion *ar;
- uiBut *postbut;
- uiButtonActivateType posttype;
int retval;
- data = but->active;
block = but->block;
ar = data->region;
@@ -6304,14 +6302,28 @@
}
if (data->state == BUTTON_STATE_EXIT) {
- postbut = data->postbut;
- posttype = data->posttype;
+ uiBut *post_but = data->postbut;
+ uiButtonActivateType post_type = data->posttype;
- button_activate_exit(C, but, data, (postbut == NULL), false);
+ button_activate_exit(C, but, data, (post_but == NULL), false);
/* for jumping to the next button with tab while text editing */
- if (postbut)
- button_activate_init(C, ar, postbut, posttype);
+ if (post_but) {
+ button_activate_init(C, ar, post_but, post_type);
+ }
+ else {
+ /* XXX issue is because WM_event_add_mousemove(C) is a bad hack and not reliable,
+ *if that gets coded better this bypass can go away too.
+ *
+ * This is needed to make sure if a button was active,
+ * it stays active while the mouse is over it.
+ * This avoids adding mousemoves, see: [#33466] */
+ if (ELEM(state_orig, BUTTON_ACTIVATE, BUTTON_ACTIVATE_OVER)) {
+ if (ui_but_find_mouse_over(ar, event->x, event->y) == but) {
+ button_activate_init(C, ar, but, state_orig);
+ }
+ }
+ }
}
return retval;
More information about the Bf-blender-cvs
mailing list