[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [54743] trunk/blender/source/blender/ editors/interface/interface_handlers.c: code cleanup: switch argument order for button_activate_exit() but/ data args were flipped compared to other functions.

Campbell Barton ideasman42 at gmail.com
Fri Feb 22 07:02:52 CET 2013


Revision: 54743
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=54743
Author:   campbellbarton
Date:     2013-02-22 06:02:52 +0000 (Fri, 22 Feb 2013)
Log Message:
-----------
code cleanup: switch argument order for button_activate_exit() but/data args were flipped compared to other functions.

Modified Paths:
--------------
    trunk/blender/source/blender/editors/interface/interface_handlers.c

Modified: trunk/blender/source/blender/editors/interface/interface_handlers.c
===================================================================
--- trunk/blender/source/blender/editors/interface/interface_handlers.c	2013-02-22 05:56:20 UTC (rev 54742)
+++ trunk/blender/source/blender/editors/interface/interface_handlers.c	2013-02-22 06:02:52 UTC (rev 54743)
@@ -5766,7 +5766,8 @@
 		button_activate_state(C, but, BUTTON_STATE_WAIT_FLASH);
 }
 
-static void button_activate_exit(bContext *C, uiHandleButtonData *data, uiBut *but, int mousemove, int onfree)
+static void button_activate_exit(bContext *C, uiBut *but, uiHandleButtonData *data,
+                                 const bool mousemove, const bool onfree)
 {
 	uiBlock *block = but->block;
 	uiBut *bt;
@@ -5847,7 +5848,7 @@
 	if (but->active) {
 		data = but->active;
 		data->cancel = TRUE;
-		button_activate_exit((bContext *)C, data, but, 0, 1);
+		button_activate_exit((bContext *)C, but, data, false, true);
 	}
 }
 
@@ -6083,7 +6084,7 @@
 	data->region = ar;
 	ui_apply_button(C, but->block, but, data, true);
 	/* use onfree event so undo is handled by caller and apply is already done above */
-	button_activate_exit((bContext *)C, data, but, false, true);
+	button_activate_exit((bContext *)C, but, data, false, true);
 	but->active = active_back;
 }
 
@@ -6096,7 +6097,7 @@
 	if (oldbut) {
 		data = oldbut->active;
 		data->cancel = TRUE;
-		button_activate_exit(C, data, oldbut, 0, 0);
+		button_activate_exit(C, oldbut, data, false, false);
 	}
 
 	button_activate_init(C, ar, but, type);
@@ -6268,7 +6269,7 @@
 		postbut = data->postbut;
 		posttype = data->posttype;
 
-		button_activate_exit(C, data, but, (postbut == NULL), 0);
+		button_activate_exit(C, but, data, (postbut == NULL), false);
 
 		/* for jumping to the next button with tab while text editing */
 		if (postbut)
@@ -6397,7 +6398,7 @@
 		if (menu->menuretval != UI_RETURN_OK)
 			data->cancel = TRUE;
 
-		button_activate_exit(C, data, but, 1, 0);
+		button_activate_exit(C, but, data, true, false);
 	}
 	else if (menu->menuretval & UI_RETURN_OUT) {
 		if (event->type == MOUSEMOVE && ui_mouse_inside_button(data->region, but, event->x, event->y)) {
@@ -6411,7 +6412,7 @@
 			}
 			else {
 				data->cancel = TRUE;
-				button_activate_exit(C, data, but, 1, 0);
+				button_activate_exit(C, but, data, true, false);
 			}
 		}
 	}




More information about the Bf-blender-cvs mailing list