[Bf-blender-cvs] [b78b3f2] master: Fix for out-of-bounds memcpy() when adding a material
Campbell Barton
noreply at git.blender.org
Mon Dec 16 19:48:11 CET 2013
Commit: b78b3f2ac8e44f2120f2fe14cd2f976c50977bc0
Author: Campbell Barton
Date: Tue Dec 17 05:47:22 2013 +1100
http://developer.blender.org/rBb78b3f2ac8e44f2120f2fe14cd2f976c50977bc0
Fix for out-of-bounds memcpy() when adding a material
===================================================================
M source/blender/blenkernel/intern/material.c
===================================================================
diff --git a/source/blender/blenkernel/intern/material.c b/source/blender/blenkernel/intern/material.c
index a38fce9..cf9b838 100644
--- a/source/blender/blenkernel/intern/material.c
+++ b/source/blender/blenkernel/intern/material.c
@@ -837,7 +837,6 @@ void assign_material_id(ID *id, Material *ma, short act)
void assign_material(Object *ob, Material *ma, short act, int assign_type)
{
Material *mao, **matar, ***matarar;
- char *matbits;
short *totcolp;
char bit = 0;
@@ -889,16 +888,8 @@ void assign_material(Object *ob, Material *ma, short act, int assign_type)
if (act > ob->totcol) {
/* Need more space in the material arrays */
- matar = MEM_callocN(sizeof(void *) * act, "matarray2");
- matbits = MEM_callocN(sizeof(char) * act, "matbits1");
- if (ob->totcol) {
- memcpy(matar, ob->mat, sizeof(void *) * ob->totcol);
- memcpy(matbits, ob->matbits, sizeof(char) * (*totcolp));
- MEM_freeN(ob->mat);
- MEM_freeN(ob->matbits);
- }
- ob->mat = matar;
- ob->matbits = matbits;
+ ob->mat = MEM_recallocN_id(ob->mat, sizeof(void *) * act, "matarray2");
+ ob->matbits = MEM_recallocN_id(ob->matbits, sizeof(char) * act, "matbits1");
ob->totcol = act;
}
More information about the Bf-blender-cvs
mailing list