[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [56221] trunk/blender/source/blender: from bug report [#34984] bmesh.ops.recalc_face_normals() ignores use_flip= True

[Campbell Barton]

Revision: 56221
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=56221
Author:   campbellbarton
Date:     2013-04-22 20:15:42 +0000 (Mon, 22 Apr 2013)
Log Message:
-----------
from bug report [#34984] bmesh.ops.recalc_face_normals() ignores use_flip=True

the name `use_flip` is misleading, option in fact tags faces that have been flipped, rename to `use_face_tag`

Modified Paths:
--------------
    trunk/blender/source/blender/bmesh/intern/bmesh_opdefines.c
    trunk/blender/source/blender/bmesh/operators/bmo_utils.c
    trunk/blender/source/blender/editors/mesh/editmesh_tools.c

Modified: trunk/blender/source/blender/bmesh/intern/bmesh_opdefines.c
===================================================================
--- trunk/blender/source/blender/bmesh/intern/bmesh_opdefines.c	2013-04-22 20:00:37 UTC (rev 56220)
+++ trunk/blender/source/blender/bmesh/intern/bmesh_opdefines.c	2013-04-22 20:15:42 UTC (rev 56221)
@@ -150,7 +150,7 @@
 	"recalc_face_normals",
 	/* slots_in */
 	{{"faces", BMO_OP_SLOT_ELEMENT_BUF, {BM_FACE}},
-	 {"use_flip", BMO_OP_SLOT_BOOL},  /* Reverse the result */
+	 {"use_face_tag", BMO_OP_SLOT_BOOL},  /* Tag faces that have been flipped */
 	 {{'\0'}},
 	},
 	{{{'\0'}}},  /* no output */

Modified: trunk/blender/source/blender/bmesh/operators/bmo_utils.c
===================================================================
--- trunk/blender/source/blender/bmesh/operators/bmo_utils.c	2013-04-22 20:00:37 UTC (rev 56220)
+++ trunk/blender/source/blender/bmesh/operators/bmo_utils.c	2013-04-22 20:15:42 UTC (rev 56221)
@@ -315,7 +315,7 @@
 	BMLoop *l, *l2;
 	float maxx, maxx_test, cent[3];
 	int i, i_max;
-	const bool use_flip = BMO_slot_bool_get(op->slots_in, "use_flip");
+	const bool use_flip = BMO_slot_bool_get(op->slots_in, "use_face_tag");
 
 	startf = NULL;
 	maxx = -1.0e10;

Modified: trunk/blender/source/blender/editors/mesh/editmesh_tools.c
===================================================================
--- trunk/blender/source/blender/editors/mesh/editmesh_tools.c	2013-04-22 20:00:37 UTC (rev 56220)
+++ trunk/blender/source/blender/editors/mesh/editmesh_tools.c	2013-04-22 20:15:42 UTC (rev 56221)
@@ -976,7 +976,7 @@
 	
 	/* doflip has to do with bmesh_rationalize_normals, it's an internal
 	 * thing */
-	if (!EDBM_op_callf(em, op, "recalc_face_normals faces=%hf use_flip=%b", BM_ELEM_SELECT, true))
+	if (!EDBM_op_callf(em, op, "recalc_face_normals faces=%hf use_face_tag=%b", BM_ELEM_SELECT, true))
 		return OPERATOR_CANCELLED;
 
 	if (RNA_boolean_get(op->ptr, "inside"))