[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [55824] trunk/blender/source/blender/ editors/space_image/space_image.c: Fix eternal compo refresh when having image editor with mask opened

Sergey Sharybin sergey.vfx at gmail.com
Fri Apr 5 19:27:25 CEST 2013


Revision: 55824
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=55824
Author:   nazgul
Date:     2013-04-05 17:27:25 +0000 (Fri, 05 Apr 2013)
Log Message:
-----------
Fix eternal compo refresh when having image editor with mask opened

This was a regression since 55719 and the reason is:

- image_refresh() will tag combo for re-calc when editing mask.
  This is a feature, so you could have immediate feedback on masking
  and compositing while editing mask. This is done from image_refresh().

- Color management sends NC_WINDOW notifier, so the whole window is
  updated when changing color management settings. Image editor used
  to refresh space when this notifier is sent.

  The same notifier is sent by compositor job to redraw all possible
  viewers.

Simple fix: don't refresh image space for NC_WINDOW, there's nothing
in image_refresh() which we would want to happen on NC_WINDOW event.

Modified Paths:
--------------
    trunk/blender/source/blender/editors/space_image/space_image.c

Modified: trunk/blender/source/blender/editors/space_image/space_image.c
===================================================================
--- trunk/blender/source/blender/editors/space_image/space_image.c	2013-04-05 17:10:28 UTC (rev 55823)
+++ trunk/blender/source/blender/editors/space_image/space_image.c	2013-04-05 17:27:25 UTC (rev 55824)
@@ -438,7 +438,6 @@
 		case NC_WINDOW:
 			/* notifier comes from editing color space */
 			image_scopes_tag_refresh(sa);
-			ED_area_tag_refresh(sa);
 			ED_area_tag_redraw(sa);
 			break;
 		case NC_SCENE:




More information about the Bf-blender-cvs mailing list