[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [55768] trunk/blender/source/blender: code cleanup: use bools, (float)sin/(float)cos -> sinf/cosf, more meaningful var names.
Campbell Barton
ideasman42 at gmail.com
Thu Apr 4 06:22:39 CEST 2013
Revision: 55768
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=55768
Author: campbellbarton
Date: 2013-04-04 04:22:38 +0000 (Thu, 04 Apr 2013)
Log Message:
-----------
code cleanup: use bools, (float)sin/(float)cos -> sinf/cosf, more meaningful var names.
Modified Paths:
--------------
trunk/blender/source/blender/blenkernel/intern/constraint.c
trunk/blender/source/blender/blenkernel/intern/mball.c
trunk/blender/source/blender/blenkernel/intern/object.c
trunk/blender/source/blender/blenlib/intern/math_rotation.c
trunk/blender/source/blender/editors/interface/interface_regions.c
trunk/blender/source/blender/editors/space_view3d/drawarmature.c
trunk/blender/source/blender/editors/space_view3d/view3d_edit.c
trunk/blender/source/blender/editors/transform/transform.c
trunk/blender/source/blender/editors/transform/transform_manipulator.c
Modified: trunk/blender/source/blender/blenkernel/intern/constraint.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/constraint.c 2013-04-04 03:55:43 UTC (rev 55767)
+++ trunk/blender/source/blender/blenkernel/intern/constraint.c 2013-04-04 04:22:38 UTC (rev 55768)
@@ -1204,8 +1204,8 @@
vec_to_quat(quat, dir, (short)data->trackflag, (short)data->upflag);
normalize_v3(dir);
- q[0] = (float)cos(0.5 * vec[3]);
- x1 = (float)sin(0.5 * vec[3]);
+ q[0] = cosf(0.5 * vec[3]);
+ x1 = sinf(0.5 * vec[3]);
q[1] = -x1 * dir[0];
q[2] = -x1 * dir[1];
q[3] = -x1 * dir[2];
Modified: trunk/blender/source/blender/blenkernel/intern/mball.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/mball.c 2013-04-04 03:55:43 UTC (rev 55767)
+++ trunk/blender/source/blender/blenkernel/intern/mball.c 2013-04-04 04:22:38 UTC (rev 55768)
@@ -1426,7 +1426,8 @@
while (1) {
if (i++ == RES) return;
p[0] = 0.5f * (pos[0] + neg[0]);
- if ((function(p[0], p[1], p[2])) > 0.0f) pos[0] = p[0]; else neg[0] = p[0];
+ if ((function(p[0], p[1], p[2])) > 0.0f) pos[0] = p[0];
+ else neg[0] = p[0];
}
}
@@ -1436,7 +1437,8 @@
while (1) {
if (i++ == RES) return;
p[1] = 0.5f * (pos[1] + neg[1]);
- if ((function(p[0], p[1], p[2])) > 0.0f) pos[1] = p[1]; else neg[1] = p[1];
+ if ((function(p[0], p[1], p[2])) > 0.0f) pos[1] = p[1];
+ else neg[1] = p[1];
}
}
@@ -1446,7 +1448,8 @@
while (1) {
if (i++ == RES) return;
p[2] = 0.5f * (pos[2] + neg[2]);
- if ((function(p[0], p[1], p[2])) > 0.0f) pos[2] = p[2]; else neg[2] = p[2];
+ if ((function(p[0], p[1], p[2])) > 0.0f) pos[2] = p[2];
+ else neg[2] = p[2];
}
}
Modified: trunk/blender/source/blender/blenkernel/intern/object.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/object.c 2013-04-04 03:55:43 UTC (rev 55767)
+++ trunk/blender/source/blender/blenkernel/intern/object.c 2013-04-04 04:22:38 UTC (rev 55768)
@@ -1837,8 +1837,8 @@
/* the tilt */
normalize_v3(dir);
- q[0] = (float)cos(0.5 * vec[3]);
- si = (float)sin(0.5 * vec[3]);
+ q[0] = cosf(0.5 * vec[3]);
+ si = sinf(0.5 * vec[3]);
q[1] = -si * dir[0];
q[2] = -si * dir[1];
q[3] = -si * dir[2];
Modified: trunk/blender/source/blender/blenlib/intern/math_rotation.c
===================================================================
--- trunk/blender/source/blender/blenlib/intern/math_rotation.c 2013-04-04 03:55:43 UTC (rev 55767)
+++ trunk/blender/source/blender/blenlib/intern/math_rotation.c 2013-04-04 04:22:38 UTC (rev 55768)
@@ -539,9 +539,9 @@
if ((1.0f - cosom) > 0.0001f) {
omega = (float)acos(cosom);
- sinom = (float)sin(omega);
- sc1 = (float)sin((1.0 - t) * omega) / sinom;
- sc2 = (float)sin(t * omega) / sinom;
+ sinom = sinf(omega);
+ sc1 = sinf((1.0 - t) * omega) / sinom;
+ sc2 = sinf(t * omega) / sinom;
}
else {
sc1 = 1.0f - t;
@@ -558,8 +558,8 @@
result[2] = quat2[1];
result[3] = -quat2[0];
- sc1 = (float)sin((1.0 - t) * M_PI_2);
- sc2 = (float)sin(t * M_PI_2);
+ sc1 = sinf((1.0 - t) * M_PI_2);
+ sc2 = sinf(t * M_PI_2);
result[0] = sc1 * quat1[0] + sc2 * result[0];
result[1] = sc1 * quat1[1] + sc2 * result[1];
Modified: trunk/blender/source/blender/editors/interface/interface_regions.c
===================================================================
--- trunk/blender/source/blender/editors/interface/interface_regions.c 2013-04-04 03:55:43 UTC (rev 55767)
+++ trunk/blender/source/blender/editors/interface/interface_regions.c 2013-04-04 04:22:38 UTC (rev 55768)
@@ -742,8 +742,8 @@
uiFontStyle fstyle;
uiSearchItems items;
int active; /* index in items array */
- int noback; /* when menu opened with enough space for this */
- int preview; /* draw thumbnail previews, rather than list */
+ bool noback; /* when menu opened with enough space for this */
+ bool preview; /* draw thumbnail previews, rather than list */
int prv_rows, prv_cols;
} uiSearchboxData;
@@ -1023,7 +1023,7 @@
/* pixel space */
wmOrtho2(-0.01f, ar->winx - 0.01f, -0.01f, ar->winy - 0.01f);
- if (!data->noback)
+ if (data->noback == false)
ui_draw_search_back(NULL, NULL, &data->bbox); /* style not used yet */
/* draw text */
@@ -1136,10 +1136,10 @@
/* special case, hardcoded feature, not draw backdrop when called from menus,
* assume for design that popup already added it */
if (but->block->flag & UI_BLOCK_SEARCH_MENU)
- data->noback = 1;
+ data->noback = true;
if (but->a1 > 0 && but->a2 > 0) {
- data->preview = 1;
+ data->preview = true;
data->prv_rows = but->a1;
data->prv_cols = but->a2;
}
Modified: trunk/blender/source/blender/editors/space_view3d/drawarmature.c
===================================================================
--- trunk/blender/source/blender/editors/space_view3d/drawarmature.c 2013-04-04 03:55:43 UTC (rev 55767)
+++ trunk/blender/source/blender/editors/space_view3d/drawarmature.c 2013-04-04 04:22:38 UTC (rev 55768)
@@ -1573,8 +1573,8 @@
for (i = 0; i < 3; i++) {
/* *0.5f here comes from M_PI/360.0f when rotations were still in degrees */
- amin[i] = (float)sin(pchan->limitmin[i] * 0.5f);
- amax[i] = (float)sin(pchan->limitmax[i] * 0.5f);
+ amin[i] = sinf(pchan->limitmin[i] * 0.5f);
+ amax[i] = sinf(pchan->limitmax[i] * 0.5f);
}
glScalef(1.0f, -1.0f, 1.0f);
@@ -1605,8 +1605,8 @@
phi = fac * (pchan->limitmax[2] - pchan->limitmin[2]);
i = (a == -16) ? 0 : 1;
- corner[i][0] = (float)sin(phi);
- corner[i][1] = (float)cos(phi);
+ corner[i][0] = sinf(phi);
+ corner[i][1] = cosf(phi);
corner[i][2] = 0.0f;
glVertex3fv(corner[i]);
}
@@ -1629,8 +1629,8 @@
i = (a == -16) ? 2 : 3;
corner[i][0] = 0.0f;
- corner[i][1] = (float)sin(phi);
- corner[i][2] = (float)cos(phi);
+ corner[i][1] = sinf(phi);
+ corner[i][2] = cosf(phi);
glVertex3fv(corner[i]);
}
glEnd();
Modified: trunk/blender/source/blender/editors/space_view3d/view3d_edit.c
===================================================================
--- trunk/blender/source/blender/editors/space_view3d/view3d_edit.c 2013-04-04 03:55:43 UTC (rev 55767)
+++ trunk/blender/source/blender/editors/space_view3d/view3d_edit.c 2013-04-04 04:22:38 UTC (rev 55768)
@@ -365,7 +365,8 @@
float viewquat[4]; /* working copy of rv3d->viewquat */
float trackvec[3];
float mousevec[3]; /* dolly only */
- float reverse, dist0, camzoom0;
+ float reverse;
+ float dist_prev, camzoom_prev;
float grid, far;
bool axis_snap; /* view rotate only */
float zfac;
@@ -425,8 +426,8 @@
* we may want to make this optional but for now its needed always */
ED_view3d_camera_lock_init(vod->v3d, vod->rv3d);
- vod->dist0 = rv3d->dist;
- vod->camzoom0 = rv3d->camzoom;
+ vod->dist_prev = rv3d->dist;
+ vod->camzoom_prev = rv3d->camzoom;
copy_qt_qt(vod->viewquat, rv3d->viewquat);
copy_qt_qt(vod->oldquat, rv3d->viewquat);
vod->origx = vod->oldx = event->x;
@@ -484,7 +485,7 @@
/* find a new ofs value that is along the view axis (rather than the mouse location) */
closest_to_line_v3(dvec, vod->dyn_ofs, my_pivot, my_origin);
- vod->dist0 = rv3d->dist = len_v3v3(my_pivot, dvec);
+ vod->dist_prev = rv3d->dist = len_v3v3(my_pivot, dvec);
negate_v3_v3(rv3d->ofs, dvec);
}
@@ -1711,7 +1712,7 @@
if (use_cam_zoom) {
float delta;
delta = (x - vod->origx + y - vod->origy) / 10.0f;
- vod->rv3d->camzoom = vod->camzoom0 + (zoom_invert ? -delta : delta);
+ vod->rv3d->camzoom = vod->camzoom_prev + (zoom_invert ? -delta : delta);
CLAMP(vod->rv3d->camzoom, RV3D_CAMZOOM_MIN, RV3D_CAMZOOM_MAX);
}
@@ -1746,7 +1747,7 @@
len1 = (int)sqrt((ctr[0] - x) * (ctr[0] - x) + (ctr[1] - y) * (ctr[1] - y)) + 5;
len2 = (int)sqrt((ctr[0] - vod->origx) * (ctr[0] - vod->origx) + (ctr[1] - vod->origy) * (ctr[1] - vod->origy)) + 5;
- zfac = vod->dist0 * ((float)len2 / len1) / vod->rv3d->dist;
+ zfac = vod->dist_prev * ((float)len2 / len1) / vod->rv3d->dist;
}
else { /* USER_ZOOM_DOLLY */
float len1, len2;
@@ -1766,11 +1767,11 @@
if (use_cam_zoom) {
/* zfac is ignored in this case, see below */
#if 0
- zfac = vod->camzoom0 * (2.0f * ((len1 / len2) - 1.0f) + 1.0f) / vod->rv3d->camzoom;
+ zfac = vod->camzoom_prev * (2.0f * ((len1 / len2) - 1.0f) + 1.0f) / vod->rv3d->camzoom;
#endif
}
else {
- zfac = vod->dist0 * (2.0f * ((len1 / len2) - 1.0f) + 1.0f) / vod->rv3d->dist;
+ zfac = vod->dist_prev * (2.0f * ((len1 / len2) - 1.0f) + 1.0f) / vod->rv3d->dist;
}
}
Modified: trunk/blender/source/blender/editors/transform/transform.c
===================================================================
--- trunk/blender/source/blender/editors/transform/transform.c 2013-04-04 03:55:43 UTC (rev 55767)
+++ trunk/blender/source/blender/editors/transform/transform.c 2013-04-04 04:22:38 UTC (rev 55768)
@@ -2757,8 +2757,8 @@
vec[1] = (vec[1] - cursor[1]);
- co = (float)cos(phi0);
- si = (float)sin(phi0);
+ co = cosf(phi0);
+ si = sinf(phi0);
loc[0] = -si * vec[1] + cursor[0];
loc[1] = co * vec[1] + cursor[1];
loc[2] = vec[2];
Modified: trunk/blender/source/blender/editors/transform/transform_manipulator.c
===================================================================
--- trunk/blender/source/blender/editors/transform/transform_manipulator.c 2013-04-04 03:55:43 UTC (rev 55767)
+++ trunk/blender/source/blender/editors/transform/transform_manipulator.c 2013-04-04 04:22:38 UTC (rev 55768)
@@ -719,13 +719,13 @@
side_delta = 2.0f * (float)M_PI / (float)nsides;
theta = (float)M_PI + 0.5f * ring_delta;
- cos_theta = (float)cos(theta);
- sin_theta = (float)sin(theta);
+ cos_theta = cosf(theta);
+ sin_theta = sinf(theta);
for (i = nrings - 1; i >= 0; i--) {
theta1 = theta + ring_delta;
- cos_theta1 = (float)cos(theta1);
- sin_theta1 = (float)sin(theta1);
+ cos_theta1 = cosf(theta1);
+ sin_theta1 = sinf(theta1);
@@ Diff output truncated at 10240 characters. @@
More information about the Bf-blender-cvs
mailing list