[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [50709] trunk/blender: code cleanup: warnings
Campbell Barton
ideasman42 at gmail.com
Tue Sep 18 05:15:13 CEST 2012
Revision: 50709
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=50709
Author: campbellbarton
Date: 2012-09-18 03:15:12 +0000 (Tue, 18 Sep 2012)
Log Message:
-----------
code cleanup: warnings
Modified Paths:
--------------
trunk/blender/intern/ghost/intern/GHOST_SystemX11.cpp
trunk/blender/intern/ghost/intern/GHOST_SystemX11.h
trunk/blender/source/blender/blenkernel/intern/object.c
trunk/blender/source/blender/blenkernel/intern/particle.c
trunk/blender/source/blender/editors/mask/mask_add.c
trunk/blender/source/blender/editors/mesh/meshtools.c
trunk/blender/source/blender/render/intern/raytrace/rayobject_vbvh.cpp
Modified: trunk/blender/intern/ghost/intern/GHOST_SystemX11.cpp
===================================================================
--- trunk/blender/intern/ghost/intern/GHOST_SystemX11.cpp 2012-09-18 03:14:31 UTC (rev 50708)
+++ trunk/blender/intern/ghost/intern/GHOST_SystemX11.cpp 2012-09-18 03:15:12 UTC (rev 50709)
@@ -983,8 +983,7 @@
default: {
#ifdef WITH_X11_XINPUT
- if (xe->type == window->GetXTablet().MotionEvent)
- {
+ if (xe->type == window->GetXTablet().MotionEvent) {
XDeviceMotionEvent *data = (XDeviceMotionEvent *)xe;
/* stroke might begin without leading ProxyIn event,
@@ -993,23 +992,23 @@
setTabletMode(window, data->deviceid);
window->GetXTablet().CommonData.Pressure =
- data->axis_data[2] / ((float)window->GetXTablet().PressureLevels);
-
+ data->axis_data[2] / ((float)window->GetXTablet().PressureLevels);
+
/* the (short) cast and the &0xffff is bizarre and unexplained anywhere,
* but I got garbage data without it. Found it in the xidump.c source --matt */
window->GetXTablet().CommonData.Xtilt =
- (short)(data->axis_data[3] & 0xffff) / ((float)window->GetXTablet().XtiltLevels);
+ (short)(data->axis_data[3] & 0xffff) / ((float)window->GetXTablet().XtiltLevels);
window->GetXTablet().CommonData.Ytilt =
- (short)(data->axis_data[4] & 0xffff) / ((float)window->GetXTablet().YtiltLevels);
+ (short)(data->axis_data[4] & 0xffff) / ((float)window->GetXTablet().YtiltLevels);
}
- else if (xe->type == window->GetXTablet().ProxInEvent)
- {
+ else if (xe->type == window->GetXTablet().ProxInEvent) {
XProximityNotifyEvent *data = (XProximityNotifyEvent *)xe;
setTabletMode(window, data->deviceid);
}
- else if (xe->type == window->GetXTablet().ProxOutEvent)
+ else if (xe->type == window->GetXTablet().ProxOutEvent) {
window->GetXTablet().CommonData.Active = GHOST_kTabletModeNone;
+ }
#endif // WITH_X11_XINPUT
break;
}
Modified: trunk/blender/intern/ghost/intern/GHOST_SystemX11.h
===================================================================
--- trunk/blender/intern/ghost/intern/GHOST_SystemX11.h 2012-09-18 03:14:31 UTC (rev 50708)
+++ trunk/blender/intern/ghost/intern/GHOST_SystemX11.h 2012-09-18 03:15:12 UTC (rev 50709)
@@ -210,8 +210,8 @@
#if defined(WITH_X11_XINPUT) && defined(X_HAVE_UTF8_STRING)
XIM
- getX11_XIM(
- ) {
+ getX11_XIM()
+ {
return m_xim;
}
#endif
@@ -235,7 +235,7 @@
*/
void putClipboard(GHOST_TInt8 *buffer, bool selection) const;
-#if WITH_XDND
+#ifdef WITH_XDND
/**
* Creates a drag'n'drop event and pushes it immediately onto the event queue.
* Called by GHOST_DropTargetX11 class.
Modified: trunk/blender/source/blender/blenkernel/intern/object.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/object.c 2012-09-18 03:14:31 UTC (rev 50708)
+++ trunk/blender/source/blender/blenkernel/intern/object.c 2012-09-18 03:15:12 UTC (rev 50709)
@@ -1772,7 +1772,6 @@
if (par->type == OB_MESH) {
Mesh *me = par->data;
DerivedMesh *dm;
- int count;
em = me->edit_btmesh;
@@ -1795,6 +1794,7 @@
dm = (em) ? em->derivedFinal : par->derivedFinal;
if (dm) {
+ int count = 0;
int numVerts = dm->getNumVerts(dm);
if (nr < numVerts) {
@@ -1803,7 +1803,6 @@
int i;
/* get the average of all verts with (original index == nr) */
- count = 0;
if (index) {
for (i = 0; i < numVerts; i++) {
if (index[i] == nr) {
Modified: trunk/blender/source/blender/blenkernel/intern/particle.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/particle.c 2012-09-18 03:14:31 UTC (rev 50708)
+++ trunk/blender/source/blender/blenkernel/intern/particle.c 2012-09-18 03:15:12 UTC (rev 50709)
@@ -4539,8 +4539,8 @@
/* can happen with bad pointcache or physics calculation
* since this becomes geometry, nan's and inf's crash raytrace code.
* better not allow this. */
- if (!finite(bb->vec[0]) || !finite(bb->vec[1]) || !finite(bb->vec[2]) ||
- !finite(bb->vel[0]) || !finite(bb->vel[1]) || !finite(bb->vel[2]) )
+ if ((!finite(bb->vec[0])) || (!finite(bb->vec[1])) || (!finite(bb->vec[2])) ||
+ (!finite(bb->vel[0])) || (!finite(bb->vel[1])) || (!finite(bb->vel[2])) )
{
zero_v3(bb->vec);
zero_v3(bb->vel);
Modified: trunk/blender/source/blender/editors/mask/mask_add.c
===================================================================
--- trunk/blender/source/blender/editors/mask/mask_add.c 2012-09-18 03:14:31 UTC (rev 50708)
+++ trunk/blender/source/blender/editors/mask/mask_add.c 2012-09-18 03:15:12 UTC (rev 50709)
@@ -64,7 +64,7 @@
MaskLayer *masklay, *point_masklay;
MaskSpline *point_spline;
MaskSplinePoint *point = NULL;
- float dist, co[2];
+ float dist = FLT_MAX, co[2];
int width, height;
float u;
float scalex, scaley;
@@ -125,7 +125,7 @@
cur_dist = dist_to_line_segment_v2(co, a, b);
- if (point == NULL || cur_dist < dist) {
+ if (cur_dist < dist) {
if (tangent)
sub_v2_v2v2(tangent, &diff_points[2 * i + 2], &diff_points[2 * i]);
Modified: trunk/blender/source/blender/editors/mesh/meshtools.c
===================================================================
--- trunk/blender/source/blender/editors/mesh/meshtools.c 2012-09-18 03:14:31 UTC (rev 50708)
+++ trunk/blender/source/blender/editors/mesh/meshtools.c 2012-09-18 03:15:12 UTC (rev 50709)
@@ -709,9 +709,9 @@
float fx, fy, fz;
int vx, vy, vz;
- if (!finite(co[0]) ||
- !finite(co[1]) ||
- !finite(co[2]))
+ if ((finite(co[0]) == FALSE) ||
+ (finite(co[1]) == FALSE) ||
+ (finite(co[2]) == FALSE))
{
return;
}
@@ -940,9 +940,9 @@
intptr_t poinval;
/* ignore nan verts */
- if (!finite(co[0]) ||
- !finite(co[1]) ||
- !finite(co[2]))
+ if ((finite(co[0]) == FALSE) ||
+ (finite(co[1]) == FALSE) ||
+ (finite(co[2]) == FALSE))
{
return NULL;
}
Modified: trunk/blender/source/blender/render/intern/raytrace/rayobject_vbvh.cpp
===================================================================
--- trunk/blender/source/blender/render/intern/raytrace/rayobject_vbvh.cpp 2012-09-18 03:14:31 UTC (rev 50708)
+++ trunk/blender/source/blender/render/intern/raytrace/rayobject_vbvh.cpp 2012-09-18 03:15:12 UTC (rev 50709)
@@ -152,6 +152,7 @@
}
}
+#if 0 /* UNUSED */
static void bfree(VBVHTree *tree)
{
if (tot_pushup + tot_pushdown + tot_hints + tot_moves) {
@@ -169,6 +170,7 @@
}
bvh_free(tree);
}
+#endif
/* the cast to pointer function is needed to workarround gcc bug: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11407 */
template<class Tree, int STACK_SIZE>
More information about the Bf-blender-cvs
mailing list