[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [50619] trunk/blender/source/blender: code cleanup: remove paranoid NULL checks ( these cases would crash earlier of the vars were in fact NULL)

[Campbell Barton]

Revision: 50619
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=50619
Author:   campbellbarton
Date:     2012-09-15 06:29:32 +0000 (Sat, 15 Sep 2012)
Log Message:
-----------
code cleanup: remove paranoid NULL checks (these cases would crash earlier of the vars were in fact NULL)

Modified Paths:
--------------
    trunk/blender/source/blender/avi/intern/avi.c
    trunk/blender/source/blender/compositor/intern/COM_ExecutionSystemHelper.cpp
    trunk/blender/source/blender/editors/armature/editarmature.c
    trunk/blender/source/blender/editors/object/object_hook.c
    trunk/blender/source/blender/editors/space_outliner/outliner_select.c
    trunk/blender/source/blender/editors/space_view3d/drawmesh.c
    trunk/blender/source/blender/editors/space_view3d/drawobject.c
    trunk/blender/source/blender/imbuf/intern/targa.c

Modified: trunk/blender/source/blender/avi/intern/avi.c
===================================================================
--- trunk/blender/source/blender/avi/intern/avi.c	2012-09-15 06:24:48 UTC (rev 50618)
+++ trunk/blender/source/blender/avi/intern/avi.c	2012-09-15 06:29:32 UTC (rev 50619)
@@ -734,16 +734,15 @@
 
 	fclose(movie->fp);
 
-	for (i = 0; movie->header && (i < movie->header->Streams); i++) {
-		if (movie->streams && (movie->streams[i].sf != NULL)) {
+	for (i = 0; i < movie->header->Streams; i++) {
+		if (movie->streams[i].sf != NULL) {
 			MEM_freeN(movie->streams[i].sf);
 		}
 	}
 
-	if (movie->header != NULL)
-		MEM_freeN(movie->header);
-	if (movie->streams != NULL)
-		MEM_freeN(movie->streams);
+	MEM_freeN(movie->header);
+	MEM_freeN(movie->streams);
+
 	if (movie->entries != NULL)
 		MEM_freeN(movie->entries);
 	if (movie->offset_table != NULL)
@@ -1082,15 +1081,15 @@
 
 	fclose(movie->fp);
 
-	for (i = 0; movie->header && (i < movie->header->Streams); i++) {
+	for (i = 0; i < movie->header->Streams; i++) {
 		if (movie->streams && (movie->streams[i].sf != NULL)) {
 			MEM_freeN(movie->streams[i].sf);
 		}
 	}
-	if (movie->header != NULL)
-		MEM_freeN(movie->header);
-	if (movie->entries != NULL)
-		MEM_freeN(movie->entries);
+
+	MEM_freeN(movie->header);
+	MEM_freeN(movie->entries);
+
 	if (movie->streams != NULL)
 		MEM_freeN(movie->streams);
 	if (movie->offset_table != NULL)

Modified: trunk/blender/source/blender/compositor/intern/COM_ExecutionSystemHelper.cpp
===================================================================
--- trunk/blender/source/blender/compositor/intern/COM_ExecutionSystemHelper.cpp	2012-09-15 06:24:48 UTC (rev 50618)
+++ trunk/blender/source/blender/compositor/intern/COM_ExecutionSystemHelper.cpp	2012-09-15 06:29:32 UTC (rev 50619)
@@ -79,14 +79,10 @@
 
 Node *ExecutionSystemHelper::addNode(vector<Node *>& nodes, bNode *b_node, bool inActiveGroup, bool fast)
 {
-	Node *node;
-	node = Converter::convert(b_node, fast);
+	Node *node = Converter::convert(b_node, fast);
 	node->setIsInActiveGroup(inActiveGroup);
-	if (node != NULL) {
-		addNode(nodes, node);
-		return node;
-	}
-	return NULL;
+	addNode(nodes, node);
+	return node;
 }
 void ExecutionSystemHelper::addOperation(vector<NodeOperation *>& operations, NodeOperation *operation)
 {

Modified: trunk/blender/source/blender/editors/armature/editarmature.c
===================================================================
--- trunk/blender/source/blender/editors/armature/editarmature.c	2012-09-15 06:24:48 UTC (rev 50618)
+++ trunk/blender/source/blender/editors/armature/editarmature.c	2012-09-15 06:29:32 UTC (rev 50619)
@@ -4589,7 +4589,9 @@
 	int selectmode = 0;
 	
 	/* we call this from outliner too */
-	if (ELEM(NULL, ob, ob->pose)) return;
+	if (ob->pose == NULL) {
+		return;
+	}
 	
 	/*	Determine if we're selecting or deselecting	*/
 	if (test == 1) {

Modified: trunk/blender/source/blender/editors/object/object_hook.c
===================================================================
--- trunk/blender/source/blender/editors/object/object_hook.c	2012-09-15 06:24:48 UTC (rev 50618)
+++ trunk/blender/source/blender/editors/object/object_hook.c	2012-09-15 06:29:32 UTC (rev 50619)
@@ -585,13 +585,11 @@
 static int object_hook_remove_exec(bContext *C, wmOperator *op)
 {
 	int num = RNA_enum_get(op->ptr, "modifier");
-	Object *ob = NULL;
+	Object *ob = CTX_data_edit_object(C);
 	HookModifierData *hmd = NULL;
 
-	ob = CTX_data_edit_object(C);
 	hmd = (HookModifierData *)BLI_findlink(&ob->modifiers, num);
-
-	if (!ob || !hmd) {
+	if (!hmd) {
 		BKE_report(op->reports, RPT_ERROR, "Couldn't find hook modifier");
 		return OPERATOR_CANCELLED;
 	}

Modified: trunk/blender/source/blender/editors/space_outliner/outliner_select.c
===================================================================
--- trunk/blender/source/blender/editors/space_outliner/outliner_select.c	2012-09-15 06:24:48 UTC (rev 50618)
+++ trunk/blender/source/blender/editors/space_outliner/outliner_select.c	2012-09-15 06:29:32 UTC (rev 50619)
@@ -433,8 +433,11 @@
 	
 	if (set) {
 		if (!(bone->flag & BONE_HIDDEN_P)) {
-			if (set == 2) ED_pose_deselectall(OBACT, 2);  // 2 is clear active tag
-			else ED_pose_deselectall(OBACT, 0);
+			Object *ob = OBACT;
+			if (ob) {
+				if (set == 2) ED_pose_deselectall(ob, 2);  // 2 is clear active tag
+				else ED_pose_deselectall(ob, 0);
+			}
 			
 			if (set == 2 && (bone->flag & BONE_SELECTED)) {
 				bone->flag &= ~BONE_SELECTED;
@@ -444,7 +447,7 @@
 				arm->act_bone = bone;
 			}
 			
-			WM_event_add_notifier(C, NC_OBJECT | ND_BONE_ACTIVE, OBACT);
+			WM_event_add_notifier(C, NC_OBJECT | ND_BONE_ACTIVE, ob);
 		}
 	}
 	else {

Modified: trunk/blender/source/blender/editors/space_view3d/drawmesh.c
===================================================================
--- trunk/blender/source/blender/editors/space_view3d/drawmesh.c	2012-09-15 06:24:48 UTC (rev 50618)
+++ trunk/blender/source/blender/editors/space_view3d/drawmesh.c	2012-09-15 06:29:32 UTC (rev 50619)
@@ -507,7 +507,7 @@
 					finalCol[i * 4 + j].r = 255;
 				}
 		}
-		else if (tface && mface && set_draw_settings_cached(0, tface, ma, Gtexdraw)) {
+		else if (tface && set_draw_settings_cached(0, tface, ma, Gtexdraw)) {
 			for (j = 0; j < 4; j++) {
 				finalCol[i * 4 + j].b = 255;
 				finalCol[i * 4 + j].g = 0;

Modified: trunk/blender/source/blender/editors/space_view3d/drawobject.c
===================================================================
--- trunk/blender/source/blender/editors/space_view3d/drawobject.c	2012-09-15 06:24:48 UTC (rev 50618)
+++ trunk/blender/source/blender/editors/space_view3d/drawobject.c	2012-09-15 06:29:32 UTC (rev 50619)
@@ -3305,7 +3305,8 @@
 
 		draw_em_fancy_edges(em, scene, v3d, me, cageDM, 0, eed_act);
 	}
-	if (em) {
+
+	{
 		draw_em_fancy_verts(scene, v3d, ob, em, cageDM, eve_act, rv3d);
 
 		if (me->drawflag & ME_DRAWNORMALS) {

Modified: trunk/blender/source/blender/imbuf/intern/targa.c
===================================================================
--- trunk/blender/source/blender/imbuf/intern/targa.c	2012-09-15 06:24:48 UTC (rev 50618)
+++ trunk/blender/source/blender/imbuf/intern/targa.c	2012-09-15 06:29:32 UTC (rev 50619)
@@ -682,9 +682,11 @@
 		}
 	}
 	
-	if (tga.imgdes & 0x20) IMB_flipy(ibuf);
+	if (tga.imgdes & 0x20) {
+		IMB_flipy(ibuf);
+	}
 
-	if (ibuf && ibuf->rect)
+	if (ibuf->rect)
 		IMB_convert_rgba_to_abgr(ibuf);
 	
 	return(ibuf);