[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [50476] trunk/blender: style cleanup
Campbell Barton
ideasman42 at gmail.com
Sat Sep 8 08:40:04 CEST 2012
Revision: 50476
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=50476
Author: campbellbarton
Date: 2012-09-08 06:40:03 +0000 (Sat, 08 Sep 2012)
Log Message:
-----------
style cleanup
Modified Paths:
--------------
trunk/blender/intern/utfconv/utf_winfunc.c
trunk/blender/source/blender/blenkernel/intern/implicit.c
trunk/blender/source/blender/blenlib/BLI_math_base.h
trunk/blender/source/blender/blenlib/BLI_utildefines.h
trunk/blender/source/blender/bmesh/intern/bmesh_core.c
trunk/blender/source/blender/compositor/intern/COM_OpenCLDevice.cpp
trunk/blender/source/blender/editors/mesh/editmesh_rip.c
trunk/blender/source/blender/editors/space_node/drawnode.c
trunk/blender/source/blender/python/generic/bgl.c
Modified: trunk/blender/intern/utfconv/utf_winfunc.c
===================================================================
--- trunk/blender/intern/utfconv/utf_winfunc.c 2012-09-08 01:16:40 UTC (rev 50475)
+++ trunk/blender/intern/utfconv/utf_winfunc.c 2012-09-08 06:40:03 UTC (rev 50476)
@@ -37,7 +37,7 @@
{
FILE *f = NULL;
UTF16_ENCODE(filename);
- UTF16_ENCODE (mode);
+ UTF16_ENCODE(mode);
if (filename_16 && mode_16) {
f = _wfopen(filename_16, mode_16);
@@ -79,9 +79,11 @@
{
int r = -1;
UTF16_ENCODE(oldname);
- UTF16_ENCODE (newname);
+ UTF16_ENCODE(newname);
- if (oldname_16 && newname_16) r = _wrename(oldname_16, newname_16);
+ if (oldname_16 && newname_16) {
+ r = _wrename(oldname_16, newname_16);
+ }
UTF16_UN_ENCODE(newname);
UTF16_UN_ENCODE(oldname);
@@ -94,7 +96,9 @@
BOOL r = 0;
UTF16_ENCODE(pathname);
- if (pathname_16) r = CreateDirectoryW(pathname_16, NULL);
+ if (pathname_16) {
+ r = CreateDirectoryW(pathname_16, NULL);
+ }
UTF16_UN_ENCODE(pathname);
@@ -123,8 +127,11 @@
{
int r = 0;
wchar_t * str;
- if (!buffsize) return r;
+ if (!buffsize) {
+ return r;
+ }
+
UTF16_ENCODE(varname);
if (varname_16) {
str = _wgetenv(varname_16);
@@ -133,7 +140,9 @@
}
UTF16_UN_ENCODE(varname);
- if (!r) value[0] = 0;
+ if (!r) {
+ value[0] = 0;
+ }
return r;
}
@@ -143,6 +152,7 @@
int r = -1;
UTF16_ENCODE(name);
UTF16_ENCODE(value);
+
if (name_16 && value_16) {
r = (SetEnvironmentVariableW(name_16,value_16)!= 0) ? 0 : -1;
}
Modified: trunk/blender/source/blender/blenkernel/intern/implicit.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/implicit.c 2012-09-08 01:16:40 UTC (rev 50475)
+++ trunk/blender/source/blender/blenkernel/intern/implicit.c 2012-09-08 06:40:03 UTC (rev 50476)
@@ -193,7 +193,7 @@
DO_INLINE void del_lfvector(float (*fLongVector)[3])
{
if (fLongVector != NULL) {
- MEM_freeN (fLongVector);
+ MEM_freeN(fLongVector);
// cloth_aligned_free(&MEMORY_BASE, fLongVector);
}
}
@@ -523,7 +523,7 @@
DO_INLINE void del_bfmatrix(fmatrix3x3 *matrix)
{
if (matrix != NULL) {
- MEM_freeN (matrix);
+ MEM_freeN(matrix);
}
}
Modified: trunk/blender/source/blender/blenlib/BLI_math_base.h
===================================================================
--- trunk/blender/source/blender/blenlib/BLI_math_base.h 2012-09-08 01:16:40 UTC (rev 50475)
+++ trunk/blender/source/blender/blenlib/BLI_math_base.h 2012-09-08 06:40:03 UTC (rev 50476)
@@ -164,7 +164,10 @@
#endif
#ifndef CLAMP
-# define CLAMP(a, b, c) if ((a) < (b)) (a) = (b); else if ((a) > (c)) (a) = (c)
+# define CLAMP(a, b, c) { \
+ if ((a) < (b)) (a) = (b); \
+ else if ((a) > (c)) (a) = (c); \
+} (void)0
#endif
#ifdef __BLI_MATH_INLINE_H__
Modified: trunk/blender/source/blender/blenlib/BLI_utildefines.h
===================================================================
--- trunk/blender/source/blender/blenlib/BLI_utildefines.h 2012-09-08 01:16:40 UTC (rev 50475)
+++ trunk/blender/source/blender/blenlib/BLI_utildefines.h 2012-09-08 06:40:03 UTC (rev 50476)
@@ -198,7 +198,10 @@
#define INPR(v1, v2) ( (v1)[0] * (v2)[0] + (v1)[1] * (v2)[1] + (v1)[2] * (v2)[2])
/* some misc stuff.... */
-#define CLAMP(a, b, c) if ((a) < (b)) (a) = (b); else if ((a) > (c)) (a) = (c)
+#define CLAMP(a, b, c) { \
+ if ((a) < (b)) (a) = (b); \
+ else if ((a) > (c)) (a) = (c); \
+} (void)0
#define CLAMPIS(a, b, c) ((a) < (b) ? (b) : (a) > (c) ? (c) : (a))
#define CLAMPTEST(a, b, c) \
Modified: trunk/blender/source/blender/bmesh/intern/bmesh_core.c
===================================================================
--- trunk/blender/source/blender/bmesh/intern/bmesh_core.c 2012-09-08 01:16:40 UTC (rev 50475)
+++ trunk/blender/source/blender/bmesh/intern/bmesh_core.c 2012-09-08 06:40:03 UTC (rev 50476)
@@ -86,8 +86,9 @@
/* exception: don't copy the original shapekey index */
keyi = CustomData_bmesh_get(&bm->vdata, v->head.data, CD_SHAPE_KEYINDEX);
- if(keyi)
+ if (keyi) {
*keyi = ORIGINDEX_NONE;
+ }
}
BM_CHECK_ELEMENT(v);
Modified: trunk/blender/source/blender/compositor/intern/COM_OpenCLDevice.cpp
===================================================================
--- trunk/blender/source/blender/compositor/intern/COM_OpenCLDevice.cpp 2012-09-08 01:16:40 UTC (rev 50475)
+++ trunk/blender/source/blender/compositor/intern/COM_OpenCLDevice.cpp 2012-09-08 06:40:03 UTC (rev 50476)
@@ -110,7 +110,7 @@
{
if (offsetIndex != -1) {
cl_int error;
- cl_int2 offset = {operation->getWidth(), operation->getHeight()};
+ cl_int2 offset = {(cl_int)operation->getWidth(), (cl_int)operation->getHeight()};
error = clSetKernelArg(kernel, offsetIndex, sizeof(cl_int2), &offset);
if (error != CL_SUCCESS) { printf("CLERROR[%d]: %s\n", error, clewErrorString(error)); }
@@ -127,7 +127,7 @@
void OpenCLDevice::COM_clEnqueueRange(cl_kernel kernel, MemoryBuffer *outputMemoryBuffer)
{
cl_int error;
- const size_t size[] = {outputMemoryBuffer->getWidth(), outputMemoryBuffer->getHeight()};
+ const size_t size[] = {(size_t)outputMemoryBuffer->getWidth(), (size_t)outputMemoryBuffer->getHeight()};
error = clEnqueueNDRangeKernel(this->m_queue, kernel, 2, NULL, size, 0, 0, 0, NULL);
if (error != CL_SUCCESS) { printf("CLERROR[%d]: %s\n", error, clewErrorString(error)); }
@@ -144,7 +144,10 @@
size_t size[2];
cl_int2 offset;
- if (this->m_vendorID == NVIDIA) {localSize = 32;}
+ if (this->m_vendorID == NVIDIA) {
+ localSize = 32;
+ }
+
bool breaked = false;
for (offsety = 0; offsety < height && (!breaked); offsety += localSize) {
offset[1] = offsety;
@@ -154,6 +157,7 @@
else {
size[1] = height - offsety;
}
+
for (offsetx = 0; offsetx < width && (!breaked); offsetx += localSize) {
if (offsetx + localSize < width) {
size[0] = localSize;
Modified: trunk/blender/source/blender/editors/mesh/editmesh_rip.c
===================================================================
--- trunk/blender/source/blender/editors/mesh/editmesh_rip.c 2012-09-08 01:16:40 UTC (rev 50475)
+++ trunk/blender/source/blender/editors/mesh/editmesh_rip.c 2012-09-08 06:40:03 UTC (rev 50476)
@@ -464,6 +464,8 @@
dist = FLT_MAX;
+ /* in the loop below we find the best vertex to drag based on its connected geometry,
+ * either by its face corner, or connected edge (when no faces are attached) */
for (i = 0; i < vout_len; i++) {
if (BM_vert_is_wire(vout[i]) == FALSE) {
@@ -473,7 +475,8 @@
float l_mid_co[3];
BM_loop_calc_face_tangent(l, l_mid_co);
- /* scale to average of surrounding edge size, only needs to be approx */
+ /* scale to average of surrounding edge size, only needs to be approx, but should
+ * be roughly equivalent to the check below which uses the middle of the edge. */
mul_v3_fl(l_mid_co, (BM_edge_calc_length(l->e) + BM_edge_calc_length(l->prev->e)) / 2.0f);
add_v3_v3(l_mid_co, v->co);
Modified: trunk/blender/source/blender/editors/space_node/drawnode.c
===================================================================
--- trunk/blender/source/blender/editors/space_node/drawnode.c 2012-09-08 01:16:40 UTC (rev 50475)
+++ trunk/blender/source/blender/editors/space_node/drawnode.c 2012-09-08 06:40:03 UTC (rev 50476)
@@ -1326,8 +1326,9 @@
uiItemR(layout, ptr, "color_space", 0, "", ICON_NONE);
uiItemR(layout, ptr, "projection", 0, "", ICON_NONE);
- if(RNA_enum_get(ptr, "projection") == SHD_PROJ_BOX)
+ if (RNA_enum_get(ptr, "projection") == SHD_PROJ_BOX) {
uiItemR(layout, ptr, "projection_blend", 0, "Blend", ICON_NONE);
+ }
/* note: image user properties used directly here, unlike compositor image node,
* which redefines them in the node struct RNA to get proper updates.
Modified: trunk/blender/source/blender/python/generic/bgl.c
===================================================================
--- trunk/blender/source/blender/python/generic/bgl.c 2012-09-08 01:16:40 UTC (rev 50475)
+++ trunk/blender/source/blender/python/generic/bgl.c 2012-09-08 06:40:03 UTC (rev 50476)
@@ -44,7 +44,7 @@
#include "BLI_utildefines.h"
static PyObject *Buffer_new(PyTypeObject *type, PyObject *args, PyObject *kwds);
-static PyObject *Method_ShaderSource (PyObject *self, PyObject *args);
+static PyObject *Method_ShaderSource(PyObject *self, PyObject *args);
/* Buffer sequence methods */
More information about the Bf-blender-cvs
mailing list