[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [51609] trunk/blender/source/blender/ blenkernel/intern/DerivedMesh.c: bmesh todo: dont calculate normals in editmesh with modifiers applied, its assumed modifiers output correct normals at the moment.

Campbell Barton ideasman42 at gmail.com
Thu Oct 25 06:58:32 CEST 2012


Revision: 51609
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=51609
Author:   campbellbarton
Date:     2012-10-25 04:58:27 +0000 (Thu, 25 Oct 2012)
Log Message:
-----------
bmesh todo: dont calculate normals in editmesh with modifiers applied, its assumed modifiers output correct normals at the moment.

Modified Paths:
--------------
    trunk/blender/source/blender/blenkernel/intern/DerivedMesh.c

Modified: trunk/blender/source/blender/blenkernel/intern/DerivedMesh.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/DerivedMesh.c	2012-10-25 04:44:46 UTC (rev 51608)
+++ trunk/blender/source/blender/blenkernel/intern/DerivedMesh.c	2012-10-25 04:58:27 UTC (rev 51609)
@@ -2067,12 +2067,18 @@
 	}
 	else if (dm) {
 		*final_r = dm;
-		(*final_r)->calcNormals(*final_r); /* BMESH_ONLY - BMESH_TODO. check if this is needed */
+
+		/* once we support skipping normal calculation with modifiers we may want to add this back */
+#if 0	// was added for bmesh but is not needed
+		(*final_r)->calcNormals(*final_r);
+#endif
 	}
 	else if (!deformedVerts && cage_r && *cage_r) {
 		/* cage should already have up to date normals */
 		*final_r = *cage_r;
-		(*final_r)->calcNormals(*final_r); /* BMESH_ONLY - BMESH_TODO. check if this is needed */
+#if 0	// was added for bmesh but is not needed
+		(*final_r)->calcNormals(*final_r);
+#endif
 	}
 	else {
 		/* this is just a copy of the editmesh, no need to calc normals */




More information about the Bf-blender-cvs mailing list