[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [51575] trunk/blender/source/blender/ render/intern/source/convertblender.c: Bugfix #32617

Ton Roosendaal ton at blender.org
Wed Oct 24 11:33:30 CEST 2012


Revision: 51575
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=51575
Author:   ton
Date:     2012-10-24 09:33:29 +0000 (Wed, 24 Oct 2012)
Log Message:
-----------
Bugfix #32617

Text object render error.

Issue was caused by FLT_EPSILON being used to check for zero-sized faces, for
getting a reliable normal of front/backfaces of polygons. This value is too
small, giving occasional bad looking faces.

In other parts of code FLT_EPSILON10 was being used, that works much better.

Note for the future: here using doubles internally would be advised.

Modified Paths:
--------------
    trunk/blender/source/blender/render/intern/source/convertblender.c

Modified: trunk/blender/source/blender/render/intern/source/convertblender.c
===================================================================
--- trunk/blender/source/blender/render/intern/source/convertblender.c	2012-10-24 09:07:54 UTC (rev 51574)
+++ trunk/blender/source/blender/render/intern/source/convertblender.c	2012-10-24 09:33:29 UTC (rev 51575)
@@ -2884,8 +2884,7 @@
 						vlr->v2= RE_findOrAddVert(obr, startvert+index[1]);
 						vlr->v3= RE_findOrAddVert(obr, startvert+index[2]);
 						vlr->v4= NULL;
-
-						if (area_tri_v3(vlr->v3->co, vlr->v2->co, vlr->v1->co)>FLT_EPSILON) {
+						if (area_tri_v3(vlr->v3->co, vlr->v2->co, vlr->v1->co)>FLT_EPSILON10) {
 							normal_tri_v3(tmp, vlr->v3->co, vlr->v2->co, vlr->v1->co);
 							add_v3_v3(n, tmp);
 						}




More information about the Bf-blender-cvs mailing list