[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [51546] trunk/blender/source/blender/imbuf /intern/dds/dds_api.cpp: Fix #32837: DDS images flipped in viewport compared to render.

Brecht Van Lommel brechtvanlommel at pandora.be
Tue Oct 23 17:46:44 CEST 2012


Revision: 51546
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=51546
Author:   blendix
Date:     2012-10-23 15:46:44 +0000 (Tue, 23 Oct 2012)
Log Message:
-----------
Fix #32837: DDS images flipped in viewport compared to render. This happened
after adding compressed DDS texture loading.

DDS images can be flipped compared to the Blender standard, however we do not
unflip them because we also don't flip compressed textures. If we would flip
those we'd need to uncompress, flip and recompress them, and so losing the
speed benefit that you get from using them. Users are expected to save DDS
image in OpenGL compatible format.

Modified Paths:
--------------
    trunk/blender/source/blender/imbuf/intern/dds/dds_api.cpp

Modified: trunk/blender/source/blender/imbuf/intern/dds/dds_api.cpp
===================================================================
--- trunk/blender/source/blender/imbuf/intern/dds/dds_api.cpp	2012-10-23 15:30:41 UTC (rev 51545)
+++ trunk/blender/source/blender/imbuf/intern/dds/dds_api.cpp	2012-10-23 15:46:44 UTC (rev 51546)
@@ -169,7 +169,13 @@
 			ibuf->dds_data.size = 0;
 		}
 
-		IMB_flipy(ibuf);
+		/* DDS images can be flipped compared to the Blender standard, however we
+		 * do not unflip them because we also don't flip compressed textures. If
+		 * we would flip those we'd need to uncompress, flip and recompress them,
+		 * and so losing the speed benefit that you get from using them. Users are
+		 * expected to save DDS image in OpenGL compatible format. */
+
+		/* IMB_flipy(ibuf); */
 	}
 
 	return(ibuf);




More information about the Bf-blender-cvs mailing list