[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [51452] trunk/blender/source/blender/ makesrna/intern/rna_wm.c: add comment about misuse of enum set function.

[Campbell Barton]

Revision: 51452
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=51452
Author:   campbellbarton
Date:     2012-10-20 14:16:56 +0000 (Sat, 20 Oct 2012)
Log Message:
-----------
add comment about misuse of enum set function.

Modified Paths:
--------------
    trunk/blender/source/blender/makesrna/intern/rna_wm.c

Modified: trunk/blender/source/blender/makesrna/intern/rna_wm.c
===================================================================
--- trunk/blender/source/blender/makesrna/intern/rna_wm.c	2012-10-20 14:13:14 UTC (rev 51451)
+++ trunk/blender/source/blender/makesrna/intern/rna_wm.c	2012-10-20 14:16:56 UTC (rev 51452)
@@ -635,11 +635,18 @@
 {
 	wmKeyMapItem *kmi = ptr->data;
 	
-	if (value == ESCKEY);
-	else if (value >= AKEY)
+	/* XXX, this should really be managed in an _itemf function,
+	 * giving a list of valid enums, then silently changing them when they are set is not
+	 * a good precedent, don't do this unless you have a good reason! */
+	if (value == ESCKEY) {
+		/* pass */
+	}
+	else if (value >= AKEY) {
 		kmi->keymodifier = value;
-	else
+	}
+	else {
 		kmi->keymodifier = 0;
+	}
 }