[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [51359] trunk/blender: MESH_OT_vert_connect was missing select flush ( newly created edges were not selected).

Campbell Barton ideasman42 at gmail.com
Tue Oct 16 05:21:28 CEST 2012


Revision: 51359
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=51359
Author:   campbellbarton
Date:     2012-10-16 03:21:22 +0000 (Tue, 16 Oct 2012)
Log Message:
-----------
MESH_OT_vert_connect was missing select flush (newly created edges were not selected).
also <120 line length for cycles property descriptions.

Modified Paths:
--------------
    trunk/blender/intern/cycles/blender/addon/properties.py
    trunk/blender/source/blender/editors/mesh/editmesh_tools.c

Modified: trunk/blender/intern/cycles/blender/addon/properties.py
===================================================================
--- trunk/blender/intern/cycles/blender/addon/properties.py	2012-10-16 01:56:54 UTC (rev 51358)
+++ trunk/blender/intern/cycles/blender/addon/properties.py	2012-10-16 03:21:22 UTC (rev 51359)
@@ -136,7 +136,8 @@
                 )
         cls.blur_glossy = FloatProperty(
                 name="Filter Glossy",
-                description="Adaptively blur glossy shaders after blurry bounces, to reduce noise at the cost of accuracy",
+                description="Adaptively blur glossy shaders after blurry bounces, "
+                            "to reduce noise at the cost of accuracy",
                 min=0.0, max=10.0,
                 default=0.0,
                 )
@@ -230,7 +231,9 @@
 
         cls.sample_clamp = FloatProperty(
                 name="Clamp",
-                description="If non-zero, the maximum value for a sample, higher values will be scaled down to avoid too much noise and slow convergence at the cost of accuracy",
+                description="If non-zero, the maximum value for a sample, "
+                            "higher values will be scaled down to avoid too "
+                            "much noise and slow convergence at the cost of accuracy",
                 min=0.0, max=1e8,
                 default=0.0,
                 )
@@ -244,7 +247,8 @@
 
         cls.preview_start_resolution = IntProperty(
                 name="Start Resolution",
-                description="Resolution to start rendering preview at, progressively increasing it to the full viewport size",
+                description="Resolution to start rendering preview at, "
+                            "progressively increasing it to the full viewport size",
                 min=8, max=16384,
                 default=64,
                 )
@@ -286,7 +290,10 @@
                 )
         cls.use_progressive_refine = BoolProperty(
                 name="Progressive Refine",
-                description="Instead of rendering each tile until it is finished, refine the whole image progressively. This renders somewhat slower, but time can be saved by manually stopping the render when the noise is low enough.",
+                description="Instead of rendering each tile until it is finished, "
+                            "refine the whole image progressively. "
+                            "This renders somewhat slower, "
+                            "but time can be saved by manually stopping the render when the noise is low enough",
                 default=False,
                 )
 
@@ -374,12 +381,15 @@
                 )
         cls.sample_as_light = BoolProperty(
                 name="Sample as Lamp",
-                description="Use direct light sampling for this material, disabling may reduce overall noise for large objects that emit little light compared to other light sources",
+                description="Use direct light sampling for this material, "
+                            "disabling may reduce overall noise for large "
+                            "objects that emit little light compared to other light sources",
                 default=True,
                 )
         cls.homogeneous_volume = BoolProperty(
                 name="Homogeneous Volume",
-                description="When using volume rendering, assume volume has the same density everywhere, for faster rendering",
+                description="When using volume rendering, assume volume has the same density everywhere, "
+                            "for faster rendering",
                 default=False,
                 )
 
@@ -423,12 +433,14 @@
                 )
         cls.sample_as_light = BoolProperty(
                 name="Sample as Lamp",
-                description="Use direct light sampling for the environment, enabling for non-solid colors is recommended",
+                description="Use direct light sampling for the environment, "
+                            "enabling for non-solid colors is recommended",
                 default=False,
                 )
         cls.sample_map_resolution = IntProperty(
                 name="Map Resolution",
-                description="Importance map size is resolution x resolution; higher values potentially produce less noise, at the cost of memory and speed",
+                description="Importance map size is resolution x resolution; "
+                            "higher values potentially produce less noise, at the cost of memory and speed",
                 min=4, max=8096,
                 default=256,
                 )

Modified: trunk/blender/source/blender/editors/mesh/editmesh_tools.c
===================================================================
--- trunk/blender/source/blender/editors/mesh/editmesh_tools.c	2012-10-16 01:56:54 UTC (rev 51358)
+++ trunk/blender/source/blender/editors/mesh/editmesh_tools.c	2012-10-16 03:21:22 UTC (rev 51359)
@@ -1218,10 +1218,13 @@
 	if (!EDBM_op_finish(em, &bmop, op, TRUE)) {
 		return OPERATOR_CANCELLED;
 	}
-	
-	EDBM_update_generic(C, em, TRUE);
+	else {
+		EDBM_selectmode_flush(em);  /* so newly created edges get the selection state from the vertex */
 
-	return len ? OPERATOR_FINISHED : OPERATOR_CANCELLED;
+		EDBM_update_generic(C, em, TRUE);
+
+		return len ? OPERATOR_FINISHED : OPERATOR_CANCELLED;
+	}
 }
 
 void MESH_OT_vert_connect(wmOperatorType *ot)




More information about the Bf-blender-cvs mailing list