[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [52366] trunk/blender/source/blender/ windowmanager/intern/wm_draw.c: Fix #33223: Instant Crash on Window minimize

Sergey Sharybin sergey.vfx at gmail.com
Mon Nov 19 17:46:51 CET 2012


Revision: 52366
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=52366
Author:   nazgul
Date:     2012-11-19 16:46:48 +0000 (Mon, 19 Nov 2012)
Log Message:
-----------
Fix #33223: Instant Crash on Window minimize

Issue was caused by manipulating with triple buffers of minimized window.
It's more like an Intel driver bug but we can workaround it in quite clear
way by skipping draw of minimized windows.

Modified Paths:
--------------
    trunk/blender/source/blender/windowmanager/intern/wm_draw.c

Modified: trunk/blender/source/blender/windowmanager/intern/wm_draw.c
===================================================================
--- trunk/blender/source/blender/windowmanager/intern/wm_draw.c	2012-11-19 16:42:14 UTC (rev 52365)
+++ trunk/blender/source/blender/windowmanager/intern/wm_draw.c	2012-11-19 16:46:48 UTC (rev 52366)
@@ -753,6 +753,15 @@
 	GPU_free_unused_buffers();
 	
 	for (win = wm->windows.first; win; win = win->next) {
+		int state = GHOST_GetWindowState(win->ghostwin);;
+
+		if (state == GHOST_kWindowStateMinimized) {
+			/* do not update minimized windows, it gives issues on intel drivers (see [#33223])
+			 * anyway, it seems logical to skip update for invisile windows
+			 */
+			continue;
+		}
+
 		if (win->drawmethod != U.wmdrawmethod) {
 			wm_draw_window_clear(win);
 			win->drawmethod = U.wmdrawmethod;




More information about the Bf-blender-cvs mailing list