[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [46981] trunk/blender/source/blender/ blenkernel/intern/smoke.c: Smoke: Fix wrong maximum timestep, resulting in exploding/unstable fluids.

Daniel Genrich daniel.genrich at gmx.net
Thu May 24 20:22:37 CEST 2012


Revision: 46981
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=46981
Author:   genscher
Date:     2012-05-24 18:22:36 +0000 (Thu, 24 May 2012)
Log Message:
-----------
Smoke: Fix wrong maximum timestep, resulting in exploding/unstable fluids.

Part of my Smoke Development project.
In conjunction with MiikaH and his gSoC project.

Modified Paths:
--------------
    trunk/blender/source/blender/blenkernel/intern/smoke.c

Modified: trunk/blender/source/blender/blenkernel/intern/smoke.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/smoke.c	2012-05-24 16:37:40 UTC (rev 46980)
+++ trunk/blender/source/blender/blenkernel/intern/smoke.c	2012-05-24 18:22:36 UTC (rev 46981)
@@ -1598,8 +1598,8 @@
 	/* adapt timestep for different framerates, dt = 0.1 is at 25fps */
 	dt *= (25.0f / fps);
 
-	// printf("test maxVel: %f\n", (sds->dx * 1.5) / dt); // gives 0.9
-	maxVel = (sds->dx * 1.5);
+	// maximum timestep/"CFL" constraint: dt < dx * maxVel
+	maxVel = (sds->dx * 1.0);
 
 	for(i = 0; i < size; i++)
 	{




More information about the Bf-blender-cvs mailing list