[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [46642] trunk/blender/source/blender/bmesh /operators/bmo_hull.c: Partial fix for bug #31458 Convex Hull operator crash

Nicholas Bishop nicholasbishop at gmail.com
Mon May 14 22:59:08 CEST 2012


Revision: 46642
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=46642
Author:   nicholasbishop
Date:     2012-05-14 20:59:08 +0000 (Mon, 14 May 2012)
Log Message:
-----------
Partial fix for bug #31458 Convex Hull operator crash

Change hull's point/triangle side test to > rather than >=.

This seems to fix the (infinite?) loop, but not the crash.

Modified Paths:
--------------
    trunk/blender/source/blender/bmesh/operators/bmo_hull.c

Modified: trunk/blender/source/blender/bmesh/operators/bmo_hull.c
===================================================================
--- trunk/blender/source/blender/bmesh/operators/bmo_hull.c	2012-05-14 20:58:59 UTC (rev 46641)
+++ trunk/blender/source/blender/bmesh/operators/bmo_hull.c	2012-05-14 20:59:08 UTC (rev 46642)
@@ -161,7 +161,7 @@
 	GHASH_ITER (iter, hull_triangles) {
 		HullTriangle *t = BLI_ghashIterator_getKey(&iter);
 		
-		if (hull_point_tri_side(t, v->co) >= 0)
+		if (hull_point_tri_side(t, v->co) > 0)
 			BLI_ghash_insert(outside, t, NULL);
 	}
 




More information about the Bf-blender-cvs mailing list