[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [46385] trunk/blender/source/blender/ modifiers/intern/MOD_solidify.c: fix for solidify modifier angle calculation ( was incorrectly using normalized angle function)

Campbell Barton ideasman42 at gmail.com
Mon May 7 17:45:41 CEST 2012


Revision: 46385
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=46385
Author:   campbellbarton
Date:     2012-05-07 15:45:41 +0000 (Mon, 07 May 2012)
Log Message:
-----------
fix for solidify modifier angle calculation (was incorrectly using normalized angle function)

Modified Paths:
--------------
    trunk/blender/source/blender/modifiers/intern/MOD_solidify.c

Modified: trunk/blender/source/blender/modifiers/intern/MOD_solidify.c
===================================================================
--- trunk/blender/source/blender/modifiers/intern/MOD_solidify.c	2012-05-07 13:42:25 UTC (rev 46384)
+++ trunk/blender/source/blender/modifiers/intern/MOD_solidify.c	2012-05-07 15:45:41 UTC (rev 46385)
@@ -474,16 +474,16 @@
 			
 			/* just added, calc the normal */
 			BLI_array_empty(face_angles);
+			BLI_array_reserve(face_angles, mp->totloop);
 			for (j = 0, ml = mloop + mp->loopstart; j < mp->totloop; j++, ml++) {
 				MLoop *ml_prev = ME_POLY_LOOP_PREV(mloop, mp, j);
 				MLoop *ml_next = ME_POLY_LOOP_NEXT(mloop, mp, j);
 
-				float e1[3], e2[3], angle;
-				
+				float e1[3], e2[3];
+
 				sub_v3_v3v3(e1, mvert[ml_next->v].co, mvert[ml->v].co);
 				sub_v3_v3v3(e2, mvert[ml_prev->v].co, mvert[ml->v].co);
-				angle = (float)M_PI - angle_normalized_v3v3(e1, e2);
-				BLI_array_append(face_angles, angle);
+				face_angles[j] = (float)M_PI - angle_v3v3(e1, e2);
 			}
 			
 			for (j = 0, ml = mloop + mp->loopstart; j < mp->totloop; j++, ml++) {




More information about the Bf-blender-cvs mailing list