[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [45113] trunk/blender/source/blender: code cleanup: use zero_v3

Campbell Barton ideasman42 at gmail.com
Fri Mar 23 21:18:10 CET 2012


Revision: 45113
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=45113
Author:   campbellbarton
Date:     2012-03-23 20:18:09 +0000 (Fri, 23 Mar 2012)
Log Message:
-----------
code cleanup: use zero_v3

Modified Paths:
--------------
    trunk/blender/source/blender/blenkernel/intern/cdderivedmesh.c
    trunk/blender/source/blender/blenkernel/intern/collision.c
    trunk/blender/source/blender/blenkernel/intern/constraint.c
    trunk/blender/source/blender/blenkernel/intern/curve.c
    trunk/blender/source/blender/blenkernel/intern/editderivedmesh.c
    trunk/blender/source/blender/blenkernel/intern/seqeffects.c
    trunk/blender/source/blender/editors/mesh/bmesh_tools.c
    trunk/blender/source/blender/editors/object/object_hook.c
    trunk/blender/source/blender/editors/space_view3d/view3d_draw.c
    trunk/blender/source/blender/editors/space_view3d/view3d_fly.c
    trunk/blender/source/blender/editors/space_view3d/view3d_snap.c
    trunk/blender/source/blender/editors/space_view3d/view3d_view.c
    trunk/blender/source/blender/editors/transform/transform_manipulator.c
    trunk/blender/source/blender/editors/transform/transform_orientations.c
    trunk/blender/source/blender/makesdna/DNA_action_types.h
    trunk/blender/source/blender/modifiers/intern/MOD_array.c

Modified: trunk/blender/source/blender/blenkernel/intern/cdderivedmesh.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/cdderivedmesh.c	2012-03-23 20:14:11 UTC (rev 45112)
+++ trunk/blender/source/blender/blenkernel/intern/cdderivedmesh.c	2012-03-23 20:18:09 UTC (rev 45113)
@@ -185,9 +185,11 @@
 		for (i=0; i<dm->numVertData; i++) {
 			DO_MINMAX(cddm->mvert[i].co, min_r, max_r);
 		}
-	} else {
-		min_r[0] = min_r[1] = min_r[2] = max_r[0] = max_r[1] = max_r[2] = 0.0;
 	}
+	else {
+		zero_v3(min_r);
+		zero_v3(max_r);
+	}
 }
 
 static void cdDM_getVertCo(DerivedMesh *dm, int index, float co_r[3])

Modified: trunk/blender/source/blender/blenkernel/intern/collision.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/collision.c	2012-03-23 20:14:11 UTC (rev 45112)
+++ trunk/blender/source/blender/blenkernel/intern/collision.c	2012-03-23 20:18:09 UTC (rev 45113)
@@ -486,10 +486,10 @@
 
 DO_INLINE void collision_interpolateOnTriangle ( float to[3], float v1[3], float v2[3], float v3[3], double w1, double w2, double w3 )
 {
-	to[0] = to[1] = to[2] = 0;
-	VECADDMUL ( to, v1, w1 );
-	VECADDMUL ( to, v2, w2 );
-	VECADDMUL ( to, v3, w3 );
+	zero_v3(to);
+	VECADDMUL(to, v1, w1);
+	VECADDMUL(to, v2, w2);
+	VECADDMUL(to, v3, w3);
 }
 
 #ifndef WITH_ELTOPO

Modified: trunk/blender/source/blender/blenkernel/intern/constraint.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/constraint.c	2012-03-23 20:14:11 UTC (rev 45112)
+++ trunk/blender/source/blender/blenkernel/intern/constraint.c	2012-03-23 20:18:09 UTC (rev 45113)
@@ -2878,7 +2878,7 @@
 	
 	data->minmaxflag = TRACK_Z;
 	data->offset = 0.0f;
-	data->cache[0] = data->cache[1] = data->cache[2] = 0.0f;
+	zero_v3(data->cache);
 	data->flag = 0;
 }
 
@@ -3535,10 +3535,9 @@
 			
 			target->release(target);
 			
-			if(fail == TRUE)
-			{
+			if (fail == TRUE) {
 				/* Don't move the point */
-				co[0] = co[1] = co[2] = 0.0f;
+				zero_v3(co);
 			}
 			
 			/* co is in local object coordinates, change it to global and update target position */

Modified: trunk/blender/source/blender/blenkernel/intern/curve.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/curve.c	2012-03-23 20:14:11 UTC (rev 45112)
+++ trunk/blender/source/blender/blenkernel/intern/curve.c	2012-03-23 20:18:09 UTC (rev 45113)
@@ -155,9 +155,8 @@
 {
 	Curve *cu;
 
-	cu= alloc_libblock(&G.main->curve, ID_CU, name);
-	
-	cu->size[0]= cu->size[1]= cu->size[2]= 1.0;
+	cu = alloc_libblock(&G.main->curve, ID_CU, name);
+	copy_v3_fl(cu->size, 1.0f);
 	cu->flag= CU_FRONT|CU_BACK|CU_DEFORM_BOUNDS_OFF|CU_PATH_RADIUS;
 	cu->pathlen= 100;
 	cu->resolu= cu->resolv= (type == OB_SURF) ? 4 : 12;
@@ -392,7 +391,7 @@
 		cu->size[1]= (max[1]-min[1])/2.0f;
 		cu->size[2]= (max[2]-min[2])/2.0f;
 
-		cu->rot[0]= cu->rot[1]= cu->rot[2]= 0.0f;
+		zero_v3(cu->rot);
 
 		if(cu->size[0]==0.0f) cu->size[0]= 1.0f;
 		else if(cu->size[0]>0.0f && cu->size[0]<0.00001f) cu->size[0]= 0.00001f;

Modified: trunk/blender/source/blender/blenkernel/intern/editderivedmesh.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/editderivedmesh.c	2012-03-23 20:14:11 UTC (rev 45112)
+++ trunk/blender/source/blender/blenkernel/intern/editderivedmesh.c	2012-03-23 20:18:09 UTC (rev 45113)
@@ -1250,7 +1250,8 @@
 		}
 	}
 	else {
-		min_r[0] = min_r[1] = min_r[2] = max_r[0] = max_r[1] = max_r[2] = 0.0;
+		zero_v3(min_r);
+		zero_v3(max_r);
 	}
 }
 static int emDM_getNumVerts(DerivedMesh *dm)

Modified: trunk/blender/source/blender/blenkernel/intern/seqeffects.c
===================================================================
--- trunk/blender/source/blender/blenkernel/intern/seqeffects.c	2012-03-23 20:14:11 UTC (rev 45112)
+++ trunk/blender/source/blender/blenkernel/intern/seqeffects.c	2012-03-23 20:18:09 UTC (rev 45113)
@@ -2205,8 +2205,8 @@
 		for (x=0;x<halfWidth;x++) {
 			index=(x+y*width)*4;
 			fx=0;
-			curColor[0]=curColor[1]=curColor[2]=0;
-			curColor2[0]=curColor2[1]=curColor2[2]=0;
+			zero_v3(curColor);
+			zero_v3(curColor2);
 
 			for (i=x-halfWidth;i<x+halfWidth;i++) {
 				if ((i>=0)&&(i<width)) {
@@ -2236,7 +2236,7 @@
 		for (x=halfWidth;x<width-halfWidth;x++) {
 			index=(x+y*width)*4;
 			fx=0;
-			curColor[0]=curColor[1]=curColor[2]=0;
+			zero_v3(curColor);
 			for (i=x-halfWidth;i<x+halfWidth;i++) {
 				curColor[0]+=map[(i+y*width)*4+GlowR]*filter[fx];
 				curColor[1]+=map[(i+y*width)*4+GlowG]*filter[fx];
@@ -2259,8 +2259,8 @@
 		for (y=0;y<halfWidth;y++) {
 			index=(x+y*width)*4;
 			fy=0;
-			curColor[0]=curColor[1]=curColor[2]=0;
-			curColor2[0]=curColor2[1]=curColor2[2]=0;
+			zero_v3(curColor);
+			zero_v3(curColor2);
 			for (i=y-halfWidth;i<y+halfWidth;i++) {
 				if ((i>=0)&&(i<height)) {
 					/*	Bottom */
@@ -2289,7 +2289,7 @@
 		for (y=halfWidth;y<height-halfWidth;y++) {
 			index=(x+y*width)*4;
 			fy=0;
-			curColor[0]=curColor[1]=curColor[2]=0;
+			zero_v3(curColor);
 			for (i=y-halfWidth;i<y+halfWidth;i++) {
 				curColor[0]+=map[(x+i*width)*4+GlowR]*filter[fy];
 				curColor[1]+=map[(x+i*width)*4+GlowG]*filter[fy];
@@ -2406,7 +2406,7 @@
 		for (x=halfWidth;x<width-halfWidth;x++) {
 			index=(x+y*width)*4;
 			fx=0;
-			curColor[0]=curColor[1]=curColor[2]=0;
+			zero_v3(curColor);
 			for (i=x-halfWidth;i<x+halfWidth;i++) {
 				curColor[0]+=map[(i+y*width)*4+GlowR]*filter[fx];
 				curColor[1]+=map[(i+y*width)*4+GlowG]*filter[fx];
@@ -2429,8 +2429,8 @@
 		for (y=0;y<halfWidth;y++) {
 			index=(x+y*width)*4;
 			fy=0;
-			curColor[0]=curColor[1]=curColor[2]=0;
-			curColor2[0]=curColor2[1]=curColor2[2]=0;
+			zero_v3(curColor);
+			zero_v3(curColor2);
 			for (i=y-halfWidth;i<y+halfWidth;i++) {
 				if ((i>=0)&&(i<height)) {
 					/*	Bottom */
@@ -2459,7 +2459,7 @@
 		for (y=halfWidth;y<height-halfWidth;y++) {
 			index=(x+y*width)*4;
 			fy=0;
-			curColor[0]=curColor[1]=curColor[2]=0;
+			zero_v3(curColor);
 			for (i=y-halfWidth;i<y+halfWidth;i++) {
 				curColor[0]+=map[(x+i*width)*4+GlowR]*filter[fy];
 				curColor[1]+=map[(x+i*width)*4+GlowG]*filter[fy];

Modified: trunk/blender/source/blender/editors/mesh/bmesh_tools.c
===================================================================
--- trunk/blender/source/blender/editors/mesh/bmesh_tools.c	2012-03-23 20:14:11 UTC (rev 45112)
+++ trunk/blender/source/blender/editors/mesh/bmesh_tools.c	2012-03-23 20:18:09 UTC (rev 45113)
@@ -322,7 +322,7 @@
 
 	BMO_op_exec(bm, &extop);
 
-	nor[0] = nor[1] = nor[2] = 0.0f;
+	zero_v3(nor);
 	
 	BMO_ITER(ele, &siter, bm, &extop, "geomout", BM_ALL) {
 		BM_elem_select_set(bm, ele, TRUE);
@@ -337,11 +337,11 @@
 
 	BMO_op_finish(bm, &extop);
 
-	if (nor[0] == 0.0f && nor[1] == 0.0f && nor[2] == 0.0f) return 'g'; // grab
-	return 'n'; // normal constraint 
+	/* grab / normal constraint */
+	return is_zero_v3(nor) ? 'g' : 'n';
+}
 
-}
-static short EDBM_Extrude_vert(Object *obedit, BMEditMesh *em, const char hflag, float *nor)
+static short EDBM_Extrude_vert(Object *obedit, BMEditMesh *em, const char hflag, float nor[3])
 {
 	BMIter iter;
 	BMEdge *eed;
@@ -435,7 +435,7 @@
 	float stacknor[3] = {0.0f, 0.0f, 0.0f};
 	float *nor = norin ? norin : stacknor;
 
-	nor[0] = nor[1] = nor[2] = 0.0f;
+	zero_v3(nor);
 
 	if (em->selectmode & SCE_SELECT_VERTEX) {
 		if (em->bm->totvertsel == 0) nr = 0;
@@ -482,12 +482,12 @@
 	}
 	else {
 		
-			/* We need to force immediate calculation here because 
-			 * transform may use derived objects (which are now stale).
-			 *
-			 * This shouldn't be necessary, derived queries should be
-			 * automatically building this data if invalid. Or something.
-			 */
+		/* We need to force immediate calculation here because
+		 * transform may use derived objects (which are now stale).
+		 *
+		 * This shouldn't be necessary, derived queries should be
+		 * automatically building this data if invalid. Or something.
+		 */
 //		DAG_object_flush_update(scene, obedit, OB_RECALC_DATA);
 		object_handle_update(scene, obedit);
 

Modified: trunk/blender/source/blender/editors/object/object_hook.c
===================================================================
--- trunk/blender/source/blender/editors/object/object_hook.c	2012-03-23 20:14:11 UTC (rev 45112)
+++ trunk/blender/source/blender/editors/object/object_hook.c	2012-03-23 20:18:09 UTC (rev 45113)
@@ -178,7 +178,7 @@
 	*indexar= index= MEM_mallocN(4*totvert, "hook indexar");
 	*tot= totvert;
 	nr= 0;
-	cent[0]= cent[1]= cent[2]= 0.0;
+	zero_v3(cent);
 	
 	a= editlatt->pntsu*editlatt->pntsv*editlatt->pntsw;
 	bp= editlatt->def;
@@ -251,7 +251,7 @@
 	*indexar= index= MEM_mallocN(4*totvert, "hook indexar");
 	*tot= totvert;
 	nr= 0;
-	cent[0]= cent[1]= cent[2]= 0.0;
+	zero_v3(cent);
 	
 	for(nu= editnurb->first; nu; nu= nu->next) {
 		if(nu->type == CU_BEZIER) {

Modified: trunk/blender/source/blender/editors/space_view3d/view3d_draw.c
===================================================================
--- trunk/blender/source/blender/editors/space_view3d/view3d_draw.c	2012-03-23 20:14:11 UTC (rev 45112)
+++ trunk/blender/source/blender/editors/space_view3d/view3d_draw.c	2012-03-23 20:18:09 UTC (rev 45113)
@@ -1599,7 +1599,7 @@
 
 				asp= ( (float)ibuf->y)/(float)ibuf->x;
 
-				vec[0] = vec[1] = vec[2] = 0.0;
+				zero_v3(vec);
 				ED_view3d_project_float_v2(ar, vec, sco, rv3d->persmat);
 				cx = sco[0];
 				cy = sco[1];

Modified: trunk/blender/source/blender/editors/space_view3d/view3d_fly.c
===================================================================
--- trunk/blender/source/blender/editors/space_view3d/view3d_fly.c	2012-03-23 20:14:11 UTC (rev 45112)
+++ trunk/blender/source/blender/editors/space_view3d/view3d_fly.c	2012-03-23 20:18:09 UTC (rev 45113)
@@ -314,7 +314,7 @@
 #ifdef NDOF_FLY_DRAW_TOOMUCH
 	fly->redraw= 1;
 #endif
-	fly->dvec_prev[0] = fly->dvec_prev[1] = fly->dvec_prev[2] = 0.0f;
+	zero_v3(fly->dvec_prev);
 
 	fly->timer = WM_event_add_timer(CTX_wm_manager(C), win, TIMER, 0.01f);
 

Modified: trunk/blender/source/blender/editors/space_view3d/view3d_snap.c
===================================================================
--- trunk/blender/source/blender/editors/space_view3d/view3d_snap.c	2012-03-23 20:14:11 UTC (rev 45112)

@@ Diff output truncated at 10240 characters. @@



More information about the Bf-blender-cvs mailing list