[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [44858] trunk/blender/source/gameengine/ Ketsji/KX_BlenderMaterial.cpp: fix [#30493] GE crashes on exit because of using freed mtfaces from tessfaces

Campbell Barton ideasman42 at gmail.com
Wed Mar 14 00:28:07 CET 2012


Revision: 44858
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=44858
Author:   campbellbarton
Date:     2012-03-13 23:28:02 +0000 (Tue, 13 Mar 2012)
Log Message:
-----------
fix [#30493] GE crashes on exit because of using freed mtfaces from tessfaces

prevent gpu_draw.c holding a pointer to a freed array.

Modified Paths:
--------------
    trunk/blender/source/gameengine/Ketsji/KX_BlenderMaterial.cpp

Modified: trunk/blender/source/gameengine/Ketsji/KX_BlenderMaterial.cpp
===================================================================
--- trunk/blender/source/gameengine/Ketsji/KX_BlenderMaterial.cpp	2012-03-13 22:27:21 UTC (rev 44857)
+++ trunk/blender/source/gameengine/Ketsji/KX_BlenderMaterial.cpp	2012-03-13 23:28:02 UTC (rev 44858)
@@ -235,8 +235,12 @@
 		mTextures[i].DisableUnit();
 	}
 
-	if( mMaterial->tface ) 
-		GPU_set_tpage(mMaterial->tface, 1, mMaterial->alphablend);
+	/* used to call with 'mMaterial->tface' but this can be a freed array,
+	 * see: [#30493], so just call with NULL, this is best since it clears
+	 * the 'lastface' pointer in GPU too - campbell */
+	if (mMaterial->tface) {
+		GPU_set_tpage(NULL, 1, mMaterial->alphablend);
+	}
 }
 
 




More information about the Bf-blender-cvs mailing list