[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [48085] trunk/blender/source/blender/ windowmanager/intern/wm_event_system.c: Fix part 2 of [#31840] Quick Explode Bugs related to it's fade option.

Bastien Montagne montagne29 at wanadoo.fr
Tue Jun 19 18:26:02 CEST 2012


Revision: 48085
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=48085
Author:   mont29
Date:     2012-06-19 16:26:01 +0000 (Tue, 19 Jun 2012)
Log Message:
-----------
Fix part 2 of [#31840] Quick Explode Bugs related to it's fade option.

This in fact had nothing to see with this operator or its fade option, reports were simply not shown when repeating an operator.

Carefully checked/tracked all calls to wm_operator_exec and WM_operator_repeat, and could not see any reason why this was this way, so I disabled this. Very easy to undo in case ugly problems arize (but I really do not expect any!).

Modified Paths:
--------------
    trunk/blender/source/blender/windowmanager/intern/wm_event_system.c

Modified: trunk/blender/source/blender/windowmanager/intern/wm_event_system.c
===================================================================
--- trunk/blender/source/blender/windowmanager/intern/wm_event_system.c	2012-06-19 16:23:52 UTC (rev 48084)
+++ trunk/blender/source/blender/windowmanager/intern/wm_event_system.c	2012-06-19 16:26:01 UTC (rev 48085)
@@ -582,7 +582,10 @@
 			wm->op_undo_depth--;
 	}
 	
-	if (retval & (OPERATOR_FINISHED | OPERATOR_CANCELLED) && repeat == 0)
+	/* XXX Disabled the repeat check to address part 2 of #31840.
+	 *     Carefully checked all calls to wm_operator_exec and WM_operator_repeat, don't see any reason
+	 *     why this was needed, but worth to note it in case something turns bad. (mont29) */
+	if (retval & (OPERATOR_FINISHED | OPERATOR_CANCELLED)/* && repeat == 0 */)
 		wm_operator_reports(C, op, retval, FALSE);
 	
 	if (retval & OPERATOR_FINISHED) {




More information about the Bf-blender-cvs mailing list