[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [47560] trunk/blender: Fix unaligned array crash in Eigen3 because of compilation option.

Benoit Bolsee benoit.bolsee at online.be
Thu Jun 7 10:05:00 CEST 2012


Revision: 47560
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=47560
Author:   ben2610
Date:     2012-06-07 08:04:58 +0000 (Thu, 07 Jun 2012)
Log Message:
-----------
Fix unaligned array crash in Eigen3 because of compilation option. The EIGEN_DONT_ALIGN_STATICALLY compilation option was added for Win32 only in revision 41283 because of some compilation problem. But this option is causing alignment problem for Eigen3 local variables when SSE optimization is enabled. I do not have any compilation problem when the option is not defined, so I just remove it as it should.

Revision Links:
--------------
    http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=41283

Modified Paths:
--------------
    trunk/blender/intern/itasc/CMakeLists.txt
    trunk/blender/intern/itasc/SConscript
    trunk/blender/source/blender/ikplugin/CMakeLists.txt
    trunk/blender/source/blender/ikplugin/SConscript

Modified: trunk/blender/intern/itasc/CMakeLists.txt
===================================================================
--- trunk/blender/intern/itasc/CMakeLists.txt	2012-06-07 08:02:48 UTC (rev 47559)
+++ trunk/blender/intern/itasc/CMakeLists.txt	2012-06-07 08:04:58 UTC (rev 47560)
@@ -318,8 +318,5 @@
 	../../extern/Eigen3/Eigen/src/Cholesky/LLT.h
 )
 
-if(WIN32)
-	add_definitions(-DEIGEN_DONT_ALIGN_STATICALLY)
-endif()
 
 blender_add_lib(bf_intern_itasc "${SRC}" "${INC}" "${INC_SYS}")

Modified: trunk/blender/intern/itasc/SConscript
===================================================================
--- trunk/blender/intern/itasc/SConscript	2012-06-07 08:02:48 UTC (rev 47559)
+++ trunk/blender/intern/itasc/SConscript	2012-06-07 08:04:58 UTC (rev 47560)
@@ -9,8 +9,5 @@
 
 defs = []
 
-if env['PLATFORM'] == 'win32':
-    defs.append('EIGEN_DONT_ALIGN_STATICALLY')
-
 env.BlenderLib ('bf_intern_itasc', sources, Split(incs), defs, libtype=['intern','player'], priority=[20,100] )
 

Modified: trunk/blender/source/blender/ikplugin/CMakeLists.txt
===================================================================
--- trunk/blender/source/blender/ikplugin/CMakeLists.txt	2012-06-07 08:02:48 UTC (rev 47559)
+++ trunk/blender/source/blender/ikplugin/CMakeLists.txt	2012-06-07 08:04:58 UTC (rev 47560)
@@ -57,8 +57,5 @@
 	)
 endif()
 
-if(WIN32)
-	add_definitions(-DEIGEN_DONT_ALIGN_STATICALLY)
-endif()
 
 blender_add_lib(bf_ikplugin "${SRC}" "${INC}" "${INC_SYS}")

Modified: trunk/blender/source/blender/ikplugin/SConscript
===================================================================
--- trunk/blender/source/blender/ikplugin/SConscript	2012-06-07 08:02:48 UTC (rev 47559)
+++ trunk/blender/source/blender/ikplugin/SConscript	2012-06-07 08:04:58 UTC (rev 47560)
@@ -8,7 +8,4 @@
 
 defs.append('WITH_IK_ITASC')
 
-if env['PLATFORM'] == 'win32':
-    defs.append('EIGEN_DONT_ALIGN_STATICALLY')
-
 env.BlenderLib ( 'bf_ikplugin', sources, Split(incs), defs, libtype=['core','player'], priority=[180, 190] )




More information about the Bf-blender-cvs mailing list