[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [49218] trunk/blender/source/blender/ editors/interface/interface_handlers.c: Fix #32004: Up/ down arrow keys can move index out of actual range of template_list

Sergey Sharybin sergey.vfx at gmail.com
Wed Jul 25 18:53:56 CEST 2012


Revision: 49218
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=49218
Author:   nazgul
Date:     2012-07-25 16:53:56 +0000 (Wed, 25 Jul 2012)
Log Message:
-----------
Fix #32004: Up/down arrow keys can move index out of actual range of template_list

Fixed by clamping current index value to 0..list_size-1 range in list event
handling function. This shouldn't give any regressions since this clamping\
happens only after template was already displayed so items counter should be
correct here.

It is still possible to set index to meaningless value by directly changing
the index value via python, but that's not in the scope of interface engine
and not currently considered a bug.

Modified Paths:
--------------
    trunk/blender/source/blender/editors/interface/interface_handlers.c

Modified: trunk/blender/source/blender/editors/interface/interface_handlers.c
===================================================================
--- trunk/blender/source/blender/editors/interface/interface_handlers.c	2012-07-25 16:46:46 UTC (rev 49217)
+++ trunk/blender/source/blender/editors/interface/interface_handlers.c	2012-07-25 16:53:56 UTC (rev 49218)
@@ -5845,6 +5845,8 @@
 			else
 				value++;
 
+			CLAMP(value, 0, pa->list_last_len - 1);
+
 			if (value < pa->list_scroll)
 				pa->list_scroll = value;
 			else if (value >= pa->list_scroll + pa->list_size)




More information about the Bf-blender-cvs mailing list