[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [48763] trunk/blender/source/blender/ editors/space_node: code cleanup: remove pointless casts (int -> short -> int)

Campbell Barton ideasman42 at gmail.com
Mon Jul 9 19:05:47 CEST 2012


Revision: 48763
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=48763
Author:   campbellbarton
Date:     2012-07-09 17:05:47 +0000 (Mon, 09 Jul 2012)
Log Message:
-----------
code cleanup: remove pointless casts (int -> short -> int)

Modified Paths:
--------------
    trunk/blender/source/blender/editors/space_node/drawnode.c
    trunk/blender/source/blender/editors/space_node/node_draw.c

Modified: trunk/blender/source/blender/editors/space_node/drawnode.c
===================================================================
--- trunk/blender/source/blender/editors/space_node/drawnode.c	2012-07-09 16:51:08 UTC (rev 48762)
+++ trunk/blender/source/blender/editors/space_node/drawnode.c	2012-07-09 17:05:47 UTC (rev 48763)
@@ -221,8 +221,10 @@
 		ofs++;
 		slen = snode->aspect_sqrt * UI_GetStringWidth(ui_name + ofs);
 	}
-	uiDefBut(block, LABEL, 0, ui_name + ofs, (short)(sock->locx - (15.0f * snode->aspect_sqrt) - slen), (short)(sock->locy - 9.0f),
-	         (short)(node->width - NODE_DY), NODE_DY,  NULL, 0, 0, 0, 0, "");
+	uiDefBut(block, LABEL, 0, ui_name + ofs,
+	         (int)(sock->locx - (15.0f * snode->aspect_sqrt) - slen), (int)(sock->locy - 9.0f),
+	         (short)(node->width - NODE_DY), (short)NODE_DY,
+	         NULL, 0, 0, 0, 0, "");
 }
 
 /* ****************** BASE DRAW FUNCTIONS FOR NEW OPERATOR NODES ***************** */
@@ -387,8 +389,8 @@
 	uiBut *bt;
 	
 	bt = uiDefButF(block, BUT_NORMAL, B_NODE_EXEC, "",
-	               (short)butr->xmin, (short)butr->xmin,
-	               butr->xmax - butr->xmin, butr->xmax - butr->xmin,
+	               (int)butr->xmin, (int)butr->xmin,
+	               (short)(butr->xmax - butr->xmin), (short)(butr->xmax - butr->xmin),
 	               nor, 0.0f, 1.0f, 0, 0, "");
 	uiButSetFunc(bt, node_normal_cb, ntree, node);
 }
@@ -827,7 +829,8 @@
 		/* backdrop title */
 		UI_ThemeColor(TH_TEXT_HI);
 	
-		layout = uiBlockLayout(gnode->block, UI_LAYOUT_VERTICAL, UI_LAYOUT_PANEL, (short)(rect.xmin + 15), (short)(rect.ymax + group_header),
+		layout = uiBlockLayout(gnode->block, UI_LAYOUT_VERTICAL, UI_LAYOUT_PANEL,
+		                       (int)(rect.xmin + 15), (int)(rect.ymax + group_header),
 		                       MIN2((int)(rect.xmax - rect.xmin - 18.0f), node_group_frame + 20), group_header, UI_GetStyle());
 		RNA_pointer_create(&ntree->id, &RNA_Node, gnode, &ptr);
 		uiTemplateIDBrowse(layout, (bContext *)C, &ptr, "node_tree", NULL, NULL, NULL);

Modified: trunk/blender/source/blender/editors/space_node/node_draw.c
===================================================================
--- trunk/blender/source/blender/editors/space_node/node_draw.c	2012-07-09 16:51:08 UTC (rev 48762)
+++ trunk/blender/source/blender/editors/space_node/node_draw.c	2012-07-09 17:05:47 UTC (rev 48763)
@@ -797,8 +797,10 @@
 	//if (node->flag & NODE_MUTED)
 	//	BLI_snprintf(showname, sizeof(showname), "[%s]", showname); // XXX - don't print into self!
 	
-	uiDefBut(node->block, LABEL, 0, showname, (short)(rct->xmin+15), (short)(rct->ymax-NODE_DY), 
-			 (int)(iconofs - rct->xmin-18.0f), NODE_DY,  NULL, 0, 0, 0, 0, "");
+	uiDefBut(node->block, LABEL, 0, showname,
+	         (int)(rct->xmin + 15), (int)(rct->ymax - NODE_DY),
+	         (short)(iconofs - rct->xmin - 18.0f), (short)NODE_DY,
+	         NULL, 0, 0, 0, 0, "");
 
 	/* body */
 	if (node->flag & NODE_CUSTOM_COLOR)
@@ -946,8 +948,10 @@
 		//if (node->flag & NODE_MUTED)
 		//	BLI_snprintf(showname, sizeof(showname), "[%s]", showname); // XXX - don't print into self!
 
-		uiDefBut(node->block, LABEL, 0, showname, (short)(rct->xmin+15), (short)(centy-10), 
-				 (int)(rct->xmax - rct->xmin-18.0f -12.0f), NODE_DY,  NULL, 0, 0, 0, 0, "");
+		uiDefBut(node->block, LABEL, 0, showname,
+		         (int)(rct->xmin + 15), (int)(centy - 10),
+		         (short)(rct->xmax - rct->xmin-18.0f -12.0f), (short)NODE_DY,
+		         NULL, 0, 0, 0, 0, "");
 	}	
 
 	/* scale widget thing */




More information about the Bf-blender-cvs mailing list