[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [43934] trunk/blender/source/blender/ editors: Code Cleanup:
Campbell Barton
ideasman42 at gmail.com
Mon Feb 6 23:17:53 CET 2012
Revision: 43934
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=43934
Author: campbellbarton
Date: 2012-02-06 22:17:41 +0000 (Mon, 06 Feb 2012)
Log Message:
-----------
Code Cleanup:
don't call CTX_data_scene(C) for every marker drawn
also remove unneeded call when scene was already defined as well as redundant scene cast.
Modified Paths:
--------------
trunk/blender/source/blender/editors/animation/anim_markers.c
trunk/blender/source/blender/editors/interface/interface_ops.c
trunk/blender/source/blender/editors/space_clip/space_clip.c
trunk/blender/source/blender/editors/space_image/image_ops.c
trunk/blender/source/blender/editors/space_image/space_image.c
trunk/blender/source/blender/editors/space_node/node_edit.c
Modified: trunk/blender/source/blender/editors/animation/anim_markers.c
===================================================================
--- trunk/blender/source/blender/editors/animation/anim_markers.c 2012-02-06 21:00:50 UTC (rev 43933)
+++ trunk/blender/source/blender/editors/animation/anim_markers.c 2012-02-06 22:17:41 UTC (rev 43934)
@@ -439,22 +439,28 @@
void draw_markers_time(const bContext *C, int flag)
{
ListBase *markers= ED_context_get_markers(C);
- View2D *v2d= UI_view2d_fromcontext(C);
+ View2D *v2d;
TimeMarker *marker;
-
+ Scene *scene;
+
if (markers == NULL)
return;
-
+
+ scene = CTX_data_scene(C);
+ v2d = UI_view2d_fromcontext(C);
+
/* unselected markers are drawn at the first time */
for (marker= markers->first; marker; marker= marker->next) {
- if ((marker->flag & SELECT) == 0)
- draw_marker(v2d, marker, CTX_data_scene(C)->r.cfra, flag);
+ if ((marker->flag & SELECT) == 0) {
+ draw_marker(v2d, marker, scene->r.cfra, flag);
+ }
}
/* selected markers are drawn later */
for (marker= markers->first; marker; marker= marker->next) {
- if (marker->flag & SELECT)
- draw_marker(v2d, marker, CTX_data_scene(C)->r.cfra, flag);
+ if (marker->flag & SELECT) {
+ draw_marker(v2d, marker, scene->r.cfra, flag);
+ }
}
}
@@ -550,7 +556,8 @@
if (markers == NULL)
return OPERATOR_CANCELLED;
- /* two markers can't be at the same place */
+ /* prefer not having 2 markers at the same place,
+ * though the user can move them to overlap once added */
for (marker= markers->first; marker; marker= marker->next) {
if (marker->frame == frame)
return OPERATOR_CANCELLED;
Modified: trunk/blender/source/blender/editors/interface/interface_ops.c
===================================================================
--- trunk/blender/source/blender/editors/interface/interface_ops.c 2012-02-06 21:00:50 UTC (rev 43933)
+++ trunk/blender/source/blender/editors/interface/interface_ops.c 2012-02-06 22:17:41 UTC (rev 43934)
@@ -103,7 +103,8 @@
static void eyedropper_sample(bContext *C, Eyedropper *eye, int mx, int my)
{
if(RNA_property_type(eye->prop) == PROP_FLOAT) {
- const int color_manage = CTX_data_scene(C)->r.color_mgt_flag & R_COLOR_MANAGEMENT;
+ Scene *scene = CTX_data_scene(C);
+ const int color_manage = scene->r.color_mgt_flag & R_COLOR_MANAGEMENT;
float col[4];
RNA_property_float_get_array(&eye->ptr, eye->prop, col);
Modified: trunk/blender/source/blender/editors/space_clip/space_clip.c
===================================================================
--- trunk/blender/source/blender/editors/space_clip/space_clip.c 2012-02-06 21:00:50 UTC (rev 43933)
+++ trunk/blender/source/blender/editors/space_clip/space_clip.c 2012-02-06 22:17:41 UTC (rev 43934)
@@ -593,6 +593,7 @@
{
wmWindowManager *wm= CTX_wm_manager(C);
wmWindow *window= CTX_wm_window(C);
+ Scene *scene = CTX_data_scene(C);
SpaceClip *sc= (SpaceClip *)sa->spacedata.first;
ARegion *ar_main= BKE_area_find_region_type(sa, RGN_TYPE_WINDOW);
ARegion *ar_preview= clip_has_preview_region(C, sa);
@@ -634,7 +635,7 @@
ED_area_tag_redraw(sa);
}
- BKE_movieclip_user_set_frame(&sc->user, CTX_data_scene(C)->r.cfra);
+ BKE_movieclip_user_set_frame(&sc->user, scene->r.cfra);
}
/********************* main region ********************/
Modified: trunk/blender/source/blender/editors/space_image/image_ops.c
===================================================================
--- trunk/blender/source/blender/editors/space_image/image_ops.c 2012-02-06 21:00:50 UTC (rev 43933)
+++ trunk/blender/source/blender/editors/space_image/image_ops.c 2012-02-06 22:17:41 UTC (rev 43934)
@@ -594,7 +594,7 @@
/* retrieve state */
sima= CTX_wm_space_image(C);
ar= CTX_wm_region(C);
- scene= (Scene*)CTX_data_scene(C);
+ scene= CTX_data_scene(C);
obedit= CTX_data_edit_object(C);
ima= ED_space_image(sima);
@@ -1445,7 +1445,7 @@
/* retrieve state */
sima= CTX_wm_space_image(C);
- scene= (Scene*)CTX_data_scene(C);
+ scene= CTX_data_scene(C);
obedit= CTX_data_edit_object(C);
RNA_string_get(op->ptr, "name", name);
Modified: trunk/blender/source/blender/editors/space_image/space_image.c
===================================================================
--- trunk/blender/source/blender/editors/space_image/space_image.c 2012-02-06 21:00:50 UTC (rev 43933)
+++ trunk/blender/source/blender/editors/space_image/space_image.c 2012-02-06 22:17:41 UTC (rev 43934)
@@ -581,7 +581,7 @@
ima= ED_space_image(sima);
if(sima->iuser.flag & IMA_ANIM_ALWAYS)
- BKE_image_user_calc_frame(&sima->iuser, CTX_data_scene(C)->r.cfra, 0);
+ BKE_image_user_calc_frame(&sima->iuser, scene->r.cfra, 0);
/* check if we have to set the image from the editmesh */
if(ima && (ima->source==IMA_SRC_VIEWER || sima->pin));
Modified: trunk/blender/source/blender/editors/space_node/node_edit.c
===================================================================
--- trunk/blender/source/blender/editors/space_node/node_edit.c 2012-02-06 21:00:50 UTC (rev 43933)
+++ trunk/blender/source/blender/editors/space_node/node_edit.c 2012-02-06 22:17:41 UTC (rev 43934)
@@ -1341,9 +1341,10 @@
static void sample_draw(const bContext *C, ARegion *ar, void *arg_info)
{
+ Scene *scene = CTX_data_scene(C);
ImageSampleInfo *info= arg_info;
- ED_image_draw_info(ar, (CTX_data_scene(C)->r.color_mgt_flag & R_COLOR_MANAGEMENT), info->channels,
+ ED_image_draw_info(ar, (scene->r.color_mgt_flag & R_COLOR_MANAGEMENT), info->channels,
info->x, info->y, info->col, info->colf,
NULL, NULL /* zbuf - unused for nodes */
);
More information about the Bf-blender-cvs
mailing list