[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [53090] trunk/blender/source/blender/ editors/mesh/editmesh_tools.c: Fix [#33590] The Screw Tool in Edit Mode isn 't calculating the correct angle step divisions per turn.

Bastien Montagne montagne29 at wanadoo.fr
Mon Dec 17 20:26:09 CET 2012


Revision: 53090
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=53090
Author:   mont29
Date:     2012-12-17 19:26:09 +0000 (Mon, 17 Dec 2012)
Log Message:
-----------
Fix [#33590] The Screw Tool in Edit Mode isn't calculating the correct angle step divisions per turn.

Degrees were used as radians... :p
Also tweaked min values of steps and turns!

Modified Paths:
--------------
    trunk/blender/source/blender/editors/mesh/editmesh_tools.c

Modified: trunk/blender/source/blender/editors/mesh/editmesh_tools.c
===================================================================
--- trunk/blender/source/blender/editors/mesh/editmesh_tools.c	2012-12-17 18:45:13 UTC (rev 53089)
+++ trunk/blender/source/blender/editors/mesh/editmesh_tools.c	2012-12-17 19:26:09 UTC (rev 53090)
@@ -3778,7 +3778,7 @@
 
 	if (!EDBM_op_init(em, &spinop, op,
 	                  "spin geom=%hvef cent=%v axis=%v dvec=%v steps=%i angle=%f use_duplicate=%b",
-	                  BM_ELEM_SELECT, cent, axis, dvec, turns * steps, 360.0f * turns, FALSE))
+	                  BM_ELEM_SELECT, cent, axis, dvec, turns * steps, DEG2RADF(360.0f * turns), FALSE))
 	{
 		return OPERATOR_CANCELLED;
 	}
@@ -3823,8 +3823,8 @@
 	ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
 
 	/* props */
-	RNA_def_int(ot->srna, "steps", 9, 0, INT_MAX, "Steps", "Steps", 0, 256);
-	RNA_def_int(ot->srna, "turns", 1, 0, INT_MAX, "Turns", "Turns", 0, 256);
+	RNA_def_int(ot->srna, "steps", 9, 1, INT_MAX, "Steps", "Steps", 3, 256);
+	RNA_def_int(ot->srna, "turns", 1, 1, INT_MAX, "Turns", "Turns", 1, 256);
 
 	RNA_def_float_vector(ot->srna, "center", 3, NULL, -FLT_MAX, FLT_MAX,
 	                     "Center", "Center in global view space", -FLT_MAX, FLT_MAX);




More information about the Bf-blender-cvs mailing list