[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [53005] trunk/blender/intern/cycles/ blender: Cycles: make "Open Shading Language" a boolean toggle, the other option "GPU Compatible" was confusing.

Brecht Van Lommel brechtvanlommel at pandora.be
Fri Dec 14 16:26:49 CET 2012


Revision: 53005
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=53005
Author:   blendix
Date:     2012-12-14 15:26:49 +0000 (Fri, 14 Dec 2012)
Log Message:
-----------
Cycles: make "Open Shading Language" a boolean toggle, the other option "GPU Compatible" was confusing.

Modified Paths:
--------------
    trunk/blender/intern/cycles/blender/addon/properties.py
    trunk/blender/intern/cycles/blender/blender_sync.cpp

Modified: trunk/blender/intern/cycles/blender/addon/properties.py
===================================================================
--- trunk/blender/intern/cycles/blender/addon/properties.py	2012-12-14 15:17:53 UTC (rev 53004)
+++ trunk/blender/intern/cycles/blender/addon/properties.py	2012-12-14 15:26:49 UTC (rev 53005)
@@ -36,11 +36,6 @@
     ('EXPERIMENTAL', "Experimental", "Use experimental and incomplete features that might be broken or change in the future"),
     )
 
-enum_shading_systems = (
-    ('GPU_COMPATIBLE', "GPU Compatible", "Restricted shading system compatible with GPU rendering"),
-    ('OSL', "Open Shading Language", "Open Shading Language shading system that only runs on the CPU"),
-    )
-
 enum_displacement_methods = (
     ('BUMP', "Bump", "Bump mapping to simulate the appearance of displacement"),
     ('TRUE', "True", "Use true displacement only, requires fine subdivision"),
@@ -89,11 +84,9 @@
                 items=enum_feature_set,
                 default='SUPPORTED',
                 )
-        cls.shading_system = EnumProperty(
-                name="Shading System",
-                description="Shading system to use for rendering",
-                items=enum_shading_systems,
-                default='GPU_COMPATIBLE',
+        cls.shading_system = BoolProperty(
+                name="Open Shading Language",
+                description="Use Open Shading Language (CPU rendering only)",
                 )
 
         cls.progressive = BoolProperty(

Modified: trunk/blender/intern/cycles/blender/blender_sync.cpp
===================================================================
--- trunk/blender/intern/cycles/blender/blender_sync.cpp	2012-12-14 15:17:53 UTC (rev 53004)
+++ trunk/blender/intern/cycles/blender/blender_sync.cpp	2012-12-14 15:26:49 UTC (rev 53005)
@@ -289,7 +289,7 @@
 	BL::RenderSettings r = b_scene.render();
 	SceneParams params;
 	PointerRNA cscene = RNA_pointer_get(&b_scene.ptr, "cycles");
-	int shadingsystem = RNA_enum_get(&cscene, "shading_system");
+	int shadingsystem = RNA_boolean_get(&cscene, "shading_system");
 
 	if(shadingsystem == 0)
 		params.shadingsystem = SceneParams::SVM;
@@ -414,7 +414,7 @@
 		params.progressive = true;
 
 	/* shading system - scene level needs full refresh */
-	int shadingsystem = RNA_enum_get(&cscene, "shading_system");
+	int shadingsystem = RNA_boolean_get(&cscene, "shading_system");
 
 	if(shadingsystem == 0)
 		params.shadingsystem = SessionParams::SVM;




More information about the Bf-blender-cvs mailing list