[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [52949] trunk/blender/source/blender: fix another crash from missing update in Auto-Merge from r52911

Campbell Barton ideasman42 at gmail.com
Thu Dec 13 01:41:28 CET 2012


Revision: 52949
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=52949
Author:   campbellbarton
Date:     2012-12-13 00:41:23 +0000 (Thu, 13 Dec 2012)
Log Message:
-----------
fix another crash from missing update in Auto-Merge from r52911

Revision Links:
--------------
    http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=52911

Modified Paths:
--------------
    trunk/blender/source/blender/editors/mesh/editmesh_select.c
    trunk/blender/source/blender/editors/transform/transform_conversions.c
    trunk/blender/source/blender/makesrna/intern/rna_object.c

Modified: trunk/blender/source/blender/editors/mesh/editmesh_select.c
===================================================================
--- trunk/blender/source/blender/editors/mesh/editmesh_select.c	2012-12-12 22:42:55 UTC (rev 52948)
+++ trunk/blender/source/blender/editors/mesh/editmesh_select.c	2012-12-13 00:41:23 UTC (rev 52949)
@@ -107,21 +107,23 @@
 
 void EDBM_automerge(Scene *scene, Object *obedit, int update)
 {
-	BMEditMesh *em;
 	
 	if ((scene->toolsettings->automerge) &&
 	    (obedit && obedit->type == OB_MESH))
 	{
-		em = BMEdit_FromObject(obedit);
-		if (!em)
+		int ok;
+		BMEditMesh *em = BMEdit_FromObject(obedit);
+
+		if (!em) {
 			return;
+		}
 
-		BMO_op_callf(em->bm, BMO_FLAG_DEFAULTS,
-		             "automerge verts=%hv dist=%f",
-		             BM_ELEM_SELECT, scene->toolsettings->doublimit);
-		if (update) {
-			DAG_id_tag_update(obedit->data, OB_RECALC_DATA);
-			BMEdit_RecalcTessellation(em);
+		ok = BMO_op_callf(em->bm, BMO_FLAG_DEFAULTS,
+		                  "automerge verts=%hv dist=%f",
+		                  BM_ELEM_SELECT, scene->toolsettings->doublimit);
+
+		if (LIKELY(ok) && update) {
+			EDBM_update_generic(em, TRUE, TRUE);
 		}
 	}
 }

Modified: trunk/blender/source/blender/editors/transform/transform_conversions.c
===================================================================
--- trunk/blender/source/blender/editors/transform/transform_conversions.c	2012-12-12 22:42:55 UTC (rev 52948)
+++ trunk/blender/source/blender/editors/transform/transform_conversions.c	2012-12-13 00:41:23 UTC (rev 52949)
@@ -5131,7 +5131,7 @@
 					 * during cleanup - psy-fi */
 					freeSlideTempFaces(sld);
 				}
-				EDBM_automerge(t->scene, t->obedit, 1);
+				EDBM_automerge(t->scene, t->obedit, TRUE);
 			}
 			else {
 				if (t->mode == TFM_EDGE_SLIDE) {

Modified: trunk/blender/source/blender/makesrna/intern/rna_object.c
===================================================================
--- trunk/blender/source/blender/makesrna/intern/rna_object.c	2012-12-12 22:42:55 UTC (rev 52948)
+++ trunk/blender/source/blender/makesrna/intern/rna_object.c	2012-12-13 00:41:23 UTC (rev 52949)
@@ -94,6 +94,7 @@
 	{0, NULL, 0, NULL, NULL}
 };
 
+#ifndef RNA_RUNTIME
 static EnumPropertyItem dupli_items[] = {
 	{0, "NONE", 0, "None", ""},
 	{OB_DUPLIFRAMES, "FRAMES", 0, "Frames", "Make copy of object for every frame"},
@@ -102,6 +103,7 @@
 	{OB_DUPLIGROUP, "GROUP", 0, "Group", "Enable group instancing"},
 	{0, NULL, 0, NULL, NULL}
 };
+#endif
 
 static EnumPropertyItem collision_bounds_items[] = {
 	{OB_BOUND_BOX, "BOX", 0, "Box", ""},




More information about the Bf-blender-cvs mailing list