[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [52710] trunk/blender/source/blender/ editors/interface/interface_regions.c: left in unused code in previous commit, also remove #if 0' d code which is now replaced by uiButGetStrInfo().
Campbell Barton
ideasman42 at gmail.com
Sun Dec 2 08:23:13 CET 2012
Revision: 52710
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=52710
Author: campbellbarton
Date: 2012-12-02 07:23:10 +0000 (Sun, 02 Dec 2012)
Log Message:
-----------
left in unused code in previous commit, also remove #if 0'd code which is now replaced by uiButGetStrInfo().
Modified Paths:
--------------
trunk/blender/source/blender/editors/interface/interface_regions.c
Modified: trunk/blender/source/blender/editors/interface/interface_regions.c
===================================================================
--- trunk/blender/source/blender/editors/interface/interface_regions.c 2012-12-02 07:13:19 UTC (rev 52709)
+++ trunk/blender/source/blender/editors/interface/interface_regions.c 2012-12-02 07:23:10 UTC (rev 52710)
@@ -444,46 +444,7 @@
/* special case, enum rna buttons only have enum item description,
* use general enum description too before the specific one */
-#if 0
- if (but->rnaprop && RNA_property_type(but->rnaprop) == PROP_ENUM) {
- const char *descr = RNA_property_description(but->rnaprop);
- if (descr && descr[0]) {
- BLI_strncpy(data->lines[data->totline], descr, sizeof(data->lines[0]));
- data->color_id[data->totline] = UI_TIP_LC_MAIN;
- data->totline++;
- }
- if (ELEM(but->type, ROW, MENU)) {
- EnumPropertyItem *item;
- int totitem, free;
- int value = (but->type == ROW) ? (int)but->hardmax : (int)ui_get_but_val(but);
-
- RNA_property_enum_items_gettexted(C, &but->rnapoin, but->rnaprop, &item, &totitem, &free);
-
- for (i = 0; i < totitem; i++) {
- if (item[i].identifier[0] && item[i].value == value) {
- if (item[i].description && item[i].description[0]) {
- BLI_snprintf(data->lines[data->totline], sizeof(data->lines[0]), "%s: %s",
- item[i].name, item[i].description);
- data->color_id[data->totline] = UI_TIP_LC_SUBMENU;
- data->totline++;
- }
- break;
- }
- }
-
- if (free) {
- MEM_freeN(item);
- }
- }
- }
-
- if (but->tip && but->tip[0] != '\0') {
- BLI_strncpy(data->lines[data->totline], but->tip, sizeof(data->lines[0]));
- data->color_id[data->totline] = UI_TIP_LC_MAIN;
- data->totline++;
- }
-#else
/* Tip */
if (but_tip.strinfo) {
BLI_strncpy(data->lines[data->totline], but_tip.strinfo, sizeof(data->lines[0]));
@@ -497,29 +458,13 @@
data->color_id[data->totline] = UI_TIP_LC_SUBMENU;
data->totline++;
}
-#endif
-#if 0
- if (but->optype && !(but->block->flag & UI_BLOCK_LOOP)) {
- /* operator keymap (not menus, they already have it) */
- prop = (but->opptr) ? but->opptr->data : NULL;
-
- if (WM_key_event_operator_string(C, but->optype->idname, but->opcontext, prop, TRUE,
- buf, sizeof(buf)))
- {
- BLI_snprintf(data->lines[data->totline], sizeof(data->lines[0]), TIP_("Shortcut: %s"), buf);
- data->color_id[data->totline] = UI_TIP_LC_NORMAL;
- data->totline++;
- }
- }
-#else
/* Op shortcut */
if (op_keymap.strinfo) {
BLI_snprintf(data->lines[data->totline], sizeof(data->lines[0]), TIP_("Shortcut: %s"), op_keymap.strinfo);
data->color_id[data->totline] = UI_TIP_LC_NORMAL;
data->totline++;
}
-#endif
if (ELEM3(but->type, TEX, IDPOIN, SEARCH_MENU)) {
/* full string */
@@ -553,15 +498,7 @@
data->totline++;
}
}
-#if 0
- /* rna info */
- if ((U.flag & USER_TOOLTIPS_PYTHON) == 0) {
- BLI_snprintf(data->lines[data->totline], sizeof(data->lines[0]), TIP_("Python: %s.%s"),
- RNA_struct_identifier(but->rnapoin.type), RNA_property_identifier(but->rnaprop));
- data->color_id[data->totline] = UI_TIP_LC_PYTHON;
- data->totline++;
- }
-#endif
+
if (but->rnapoin.id.data) {
ID *id = but->rnapoin.id.data;
if (id->lib && id->lib->name) {
@@ -603,18 +540,6 @@
}
}
}
-#if 0
- else if (ELEM(but->type, MENU, PULLDOWN)) {
- if ((U.flag & USER_TOOLTIPS_PYTHON) == 0) {
- MenuType *mt = uiButGetMenuType(but);
- if (mt) {
- BLI_snprintf(data->lines[data->totline], sizeof(data->lines[0]), TIP_("Python: %s"), mt->idname);
- data->color_id[data->totline] = UI_TIP_LC_PYTHON;
- data->totline++;
- }
- }
- }
-#else
if ((U.flag & USER_TOOLTIPS_PYTHON) == 0 && !but->optype && rna_struct.strinfo) {
if (rna_prop.strinfo) {
/* Struct and prop */
@@ -636,12 +561,9 @@
PropertyRNA *prop = but->rnaprop;
ID *id = ptr->id.data;
- char name_escape[(sizeof(id->name) - 2) * 2];
char *id_path;
char *data_path = NULL;
- BLI_strescape(name_escape, id->name + 2, sizeof(name_escape));
-
/* never fails */
id_path = RNA_path_from_ID_python(id);
@@ -667,7 +589,6 @@
data->totline++;
}
}
-#endif
/* Free strinfo's... */
if (but_tip.strinfo)
@@ -683,7 +604,7 @@
if (rna_prop.strinfo)
MEM_freeN(rna_prop.strinfo);
- assert(data->totline < MAX_TOOLTIP_LINES);
+ BLI_assert(data->totline < MAX_TOOLTIP_LINES);
if (data->totline == 0) {
MEM_freeN(data);
More information about the Bf-blender-cvs
mailing list