[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [50236] trunk/blender/source/blender/ editors/animation/keyframes_draw.c: remove incorrect comment, add in useful one.

Campbell Barton ideasman42 at gmail.com
Mon Aug 27 10:23:52 CEST 2012


Revision: 50236
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=50236
Author:   campbellbarton
Date:     2012-08-27 08:23:51 +0000 (Mon, 27 Aug 2012)
Log Message:
-----------
remove incorrect comment, add in useful one.

Modified Paths:
--------------
    trunk/blender/source/blender/editors/animation/keyframes_draw.c

Modified: trunk/blender/source/blender/editors/animation/keyframes_draw.c
===================================================================
--- trunk/blender/source/blender/editors/animation/keyframes_draw.c	2012-08-27 06:55:33 UTC (rev 50235)
+++ trunk/blender/source/blender/editors/animation/keyframes_draw.c	2012-08-27 08:23:51 UTC (rev 50236)
@@ -852,12 +852,17 @@
 		int filter;
 		
 		/* get F-Curves to take keyframes from */
-		filter = ANIMFILTER_DATA_VISIBLE; // curves only
+		filter = ANIMFILTER_DATA_VISIBLE;
 		ANIM_animdata_filter(ac, &anim_data, filter, ac->data, ac->datatype);
 		
 		/* loop through each F-Curve, grabbing the keyframes */
 		for (ale = anim_data.first; ale; ale = ale->next) {
 
+			/* Why not use all #eAnim_KeyType here?
+			 * All of the other key types are actually "summaries" themselves, and will just end up duplicating stuff
+			 * that comes up through standard filtering of just F-Curves.
+			 * Given the way that these work, there isn't really any benefit at all from including them. - Aligorith */
+
 			switch (ale->datatype) {
 				case ALE_FCURVE:
 					fcurve_to_keylist(ale->adt, ale->data, keys, blocks);
@@ -869,9 +874,8 @@
 					gpl_to_keylist(ac->ads, ale->data, keys);
 					break;
 				default:
-					printf("%s: datatype %d unhandled\n", __func__, ale->datatype);
+					// printf("%s: datatype %d unhandled\n", __func__, ale->datatype);
 					break;
-
 			}
 		}
 




More information about the Bf-blender-cvs mailing list