[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [45822] trunk/blender/source/blender/ editors/mesh/editmesh_rip.c: fix error in recent rip refactor, also add comment.

[Campbell Barton]

Revision: 45822
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=45822
Author:   campbellbarton
Date:     2012-04-21 06:42:21 +0000 (Sat, 21 Apr 2012)
Log Message:
-----------
fix error in recent rip refactor, also add comment.

Modified Paths:
--------------
    trunk/blender/source/blender/editors/mesh/editmesh_rip.c

Modified: trunk/blender/source/blender/editors/mesh/editmesh_rip.c
===================================================================
--- trunk/blender/source/blender/editors/mesh/editmesh_rip.c	2012-04-21 00:33:36 UTC (rev 45821)
+++ trunk/blender/source/blender/editors/mesh/editmesh_rip.c	2012-04-21 06:42:21 UTC (rev 45822)
@@ -658,13 +658,19 @@
 		}
 	}
 
+	if (!edbm_rip_call_edgesplit(em, op)) {
+		return OPERATOR_CANCELLED;
+	}
+
+	/* note: the output of the bmesh operator is ignored, since we built
+	 * the contiguous loop pairs to split already, its possibe that some
+	 * edge did not split even though it was tagged which would not work
+	 * as expected (but not crash), however there are checks to ensure
+	 * tagged edges will split. So far its not been an issue. */
 	edbm_ripsel_deselect_helper(bm, eloop_pairs,
 	                            ar, projectMat, fmval);
 	MEM_freeN(eloop_pairs);
 
-	if (!edbm_rip_call_edgesplit(em, op)) {
-		return OPERATOR_CANCELLED;
-	}
 
 	return OPERATOR_FINISHED;
 }