[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [40610] trunk/blender: comment warnings as errors for MSVC - it too easily made small problems like unused vars into errors which gets annoying for non developers .
Campbell Barton
ideasman42 at gmail.com
Tue Sep 27 14:08:36 CEST 2011
Revision: 40610
http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=40610
Author: campbellbarton
Date: 2011-09-27 12:08:35 +0000 (Tue, 27 Sep 2011)
Log Message:
-----------
comment warnings as errors for MSVC - it too easily made small problems like unused vars into errors which gets annoying for non developers.
with GCC we have *some* warnings as errors which works out better.
Modified Paths:
--------------
trunk/blender/intern/ghost/CMakeLists.txt
trunk/blender/source/blender/blenkernel/CMakeLists.txt
Modified: trunk/blender/intern/ghost/CMakeLists.txt
===================================================================
--- trunk/blender/intern/ghost/CMakeLists.txt 2011-09-27 11:55:28 UTC (rev 40609)
+++ trunk/blender/intern/ghost/CMakeLists.txt 2011-09-27 12:08:35 UTC (rev 40610)
@@ -248,9 +248,10 @@
endif()
elseif(WIN32)
- if(MSVC)
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /WX")
- endif()
+ ## Warnings as errors, this is too strict!
+ #if(MSVC)
+ # set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /WX")
+ #endif()
list(APPEND INC_SYS
${WINTAB_INC}
Modified: trunk/blender/source/blender/blenkernel/CMakeLists.txt
===================================================================
--- trunk/blender/source/blender/blenkernel/CMakeLists.txt 2011-09-27 11:55:28 UTC (rev 40609)
+++ trunk/blender/source/blender/blenkernel/CMakeLists.txt 2011-09-27 12:08:35 UTC (rev 40610)
@@ -361,8 +361,9 @@
)
endif()
-if(MSVC)
- set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /WX")
-endif()
+## Warnings as errors, this is too strict!
+#if(MSVC)
+# set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /WX")
+#endif()
blender_add_lib(bf_blenkernel "${SRC}" "${INC}" "${INC_SYS}")
More information about the Bf-blender-cvs
mailing list