[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [40183] branches/bmesh/blender/source/ blender/bmesh/operators/edgesplitop.c: fix for [#28581] Rip Tool Gives Strange/Bad Results

Campbell Barton ideasman42 at gmail.com
Tue Sep 13 14:46:55 CEST 2011


Revision: 40183
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=40183
Author:   campbellbarton
Date:     2011-09-13 12:46:54 +0000 (Tue, 13 Sep 2011)
Log Message:
-----------
fix for [#28581] Rip Tool Gives Strange/Bad Results

Note that this just comments a check which I couldnt see any reason for, both edge split modifier and rip tool seem to work ok without it. so left the code in with an '#if 0'

Modified Paths:
--------------
    branches/bmesh/blender/source/blender/bmesh/operators/edgesplitop.c

Modified: branches/bmesh/blender/source/blender/bmesh/operators/edgesplitop.c
===================================================================
--- branches/bmesh/blender/source/blender/bmesh/operators/edgesplitop.c	2011-09-13 12:42:04 UTC (rev 40182)
+++ branches/bmesh/blender/source/blender/bmesh/operators/edgesplitop.c	2011-09-13 12:46:54 UTC (rev 40183)
@@ -266,11 +266,18 @@
 		BM_ITER(l, &liter, bm, BM_LOOPS_OF_FACE, f) {
 			if (!BMO_TestFlag(bm, l->e, EDGE_SEAM)) {
 				if (!verts[i]) {
+
+					/* WARNING, commented because of bug [#28581] in rip tool
+					 * I couldn't find any cases where this is needed, without
+					 * it rip tool at least works fine - campbell */
+#if 0
 					et = etags + BM_GetIndex(l->e);
 					if (ETV(et, l->v, l)) {
 						verts[i] = ETV(et, l->v, l);
 					}
-					else {
+					else
+#endif
+					{
 						verts[i] = l->v;
 					}
 				}




More information about the Bf-blender-cvs mailing list